Skip to content

Conversation

@jerbly
Copy link
Contributor

@jerbly jerbly commented Jan 10, 2026

Removed OrderedFloat and made our own OrderedF64 newtype with a schemars v1 impl. This was the cleanest way to solve this issue.

Removed a few schemars workarounds needed for <v1.

Updated the UI to handle https://json-schema.org/draft/2020-12/schema

This will close PRs: #1048 and #1035
This will fix issue: #952

@jerbly jerbly requested a review from a team as a code owner January 10, 2026 03:41
@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

❌ Patch coverage is 89.79592% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.2%. Comparing base (c7ff7cd) to head (93cf71f).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
crates/weaver_common/src/ordered_float.rs 89.7% 4 Missing ⚠️
crates/weaver_emit/src/attributes.rs 50.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1125   +/-   ##
=====================================
  Coverage   79.1%   79.2%           
=====================================
  Files        102     103    +1     
  Lines       7952    7992   +40     
=====================================
+ Hits        6294    6332   +38     
- Misses      1658    1660    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsuereth jsuereth merged commit b3f81ed into open-telemetry:main Jan 10, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants