Bluetooth: Add a callback for notifying the previous bond state. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chengkai15
approved these changes
Feb 19, 2025
chejinxian
commented
Feb 20, 2025
| * // Handle bond state change | ||
| * } | ||
| */ | ||
| typedef void (*on_bond_state_changed_callback_v2)(void* cookie, bt_address_t* addr, bt_transport_t transport, bond_state_t previous_state, bond_state_t current_state, bool is_ctkd); |
There was a problem hiding this comment.
parameter is enough？
chejinxian
commented
Feb 20, 2025
service/src/adapter_service.c
Outdated
| /* callback bonding */ | ||
| CALLBACK_FOREACH(CBLIST, adapter_callbacks_t, on_bond_state_changed, | ||
| addr, BT_TRANSPORT_BREDR, BOND_STATE_BONDING, false); | ||
| CALLBACK_FOREACH(CBLIST, adapter_callbacks_t, on_bond_state_changed_v2, | ||
| addr, BT_TRANSPORT_BREDR, previous_state, BOND_STATE_BONDING, false); |
There was a problem hiding this comment.
- initial value；
- power on；
- recommand v2 before v1.
- notify bonding once or bonding to bonding.
There was a problem hiding this comment.
LE remote cancel pair
chejinxian
commented
Feb 20, 2025
| @@ -512,6 +534,7 @@ typedef struct { | |||
| on_connect_request_callback on_connect_request; | |||
| on_connection_state_changed_callback on_connection_state_changed; | |||
| on_bond_state_changed_callback on_bond_state_changed; | |||
There was a problem hiding this comment.
client notify twice in different callback
There was a problem hiding this comment.
In order to be compatible with the way Local calls are made, the IPC message code cannot be reused.
chejinxian
force-pushed
the
dev-bt
branch
4 times, most recently
from
42ce98e to
c0a1027
Compare
bug: v/54141 Signed-off-by: chejinxian1 <chejinxian1@xiaomi.com>
hyson710
requested review from
zhongzhijie1,
Frozen935,
gzh-terry,
huangyulong3 and
liuX10
gzh-terry
reviewed
Feb 25, 2025
| * @param transport - Transport type, see @ref bt_transport_t (0: LE, 1: BR/EDR). | ||
| * @param previous_state - Previous bond state, see @ref bond_state_t. | ||
| * @param current_state - Current bond state, see @ref bond_state_t. | ||
| * @param is_ctkd - Whether cross-transport key derivation is used. |
There was a problem hiding this comment.
true if cross-transport key derivation is used.
gzh-terry
reviewed
Feb 25, 2025
| * @param current_state - Current bond state, see @ref bond_state_t. | ||
| * @param is_ctkd - Whether cross-transport key derivation is used. | ||
| * | ||
| * **Example:** |
There was a problem hiding this comment.
An empty callback is not really informative. Can remove it.
chejinxian
commented
Feb 25, 2025
| @@ -2746,11 +2774,6 @@ bt_status_t adapter_pair_request_reply(bt_address_t* addr, bool accept) | |||
| adapter_unlock(); | |||
| bt_status_t status; | |||
| status = bt_sal_pair_reply(PRIMARY_ADAPTER, addr, accept ? 0 : HCI_ERR_PAIRING_NOT_ALLOWED); | |||
| if (status == BT_STATUS_SUCCESS && accept) { | |||
chejinxian
commented
Feb 25, 2025
| @@ -544,10 +544,16 @@ static void process_bond_state_change_evt(bt_address_t* addr, bond_state_t state | |||
| { | |||
| remote_device_properties_t remote; | |||
| bt_device_t* device; | |||
| bond_state_t old_state; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bug: v/54141