Greenhills support: fix the naked_function inline asm expansion compile error #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
extinguish
commented
Dec 24, 2024
extinguish
commented
- fix the naked_function inline asm expansion compile error with Greenhills compiler
- fix the incorrect stub-function entry address of svc call
|
|
xiaoxiang781216
approved these changes
Dec 24, 2024
xiaoxiang781216
approved these changes
Dec 26, 2024
we should add "#" before the immediate value, otherwise the following build error will report: /tmp/ccAK89TT.s: Assembler messages: /tmp/ccAK89TT.s:40: Error: immediate expression requires a # prefix -- `mov r0,(3)' Signed-off-by: guoshichao <guoshichao@xiaomi.com>
the stub-function entry address is stored in r4, we should branch to the stub-function with blx r4, not r5 Signed-off-by: guoshichao <guoshichao@xiaomi.com>
extinguish
force-pushed
the
ghs_fix_naked_func_err
branch
from
aa540a8 to
93f4586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.