build(bugfix):tools/Make.defs reads the APPS DIR relative path and corrects it to an absolute path #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrects it to an absolute path The location of calling tools/Make.defs is no longer under TOPDIR. When CONFIG_APPS_DIR is set to a relative path. APPS's Make.defs will not be correctly imported. We correct the relative path to the absolute path of TOPDIR
xiaoxiang781216
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The location of calling tools/Make.defs is no longer under TOPDIR. When CONFIG_APPS_DIR is set to a relative path.
APPS's Make.defs will not be correctly imported.
We correct the relative path to the absolute path of TOPDIR
Impact
bugfix
Testing