Drivers/thermal: Fix hysteresis takes no effect error #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverting to including sim:nsh. Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Log z:cpu-thermal t:50 t:1 h:16 l:0 c:fan0 s:0|(invalid) z:cpu-thermal t:47 t:1 h:16 l:0 c:fan0 s:0|(invalid) z:cpu-thermal t:52 t:1 h:16 l:0 c:fan0 s:0|(invalid) z:cpu-thermal t:49 t:1 h:16 l:0 c:fan0 s:0|(invalid) z:cpu-thermal t:54 t:1 h:16 l:0 c:fan0 s:0|(invalid) z:cpu-thermal t:51 t:1 h:16 l:0 c:fan0 s:0|(invalid) z:cpu-thermal t:56 t:1 h:16 l:0 c:fan0 s:0|(invalid) Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Diff - z:cpu-thermal t:48 t:1 h:16 l:0 c:fan0 s:0|4294967295 + z:cpu-thermal t:48 t:1 h:16 l:0 c:fan0 s:0|(invalid) The invalid value 4294967295(THERMAL_NO_TARGET, defined as UINT_MAX(0xffffffff)) may bother users. Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Make it easier to debug. e.g. execute some commands frequently, like: cat /proc/thermal/cpu-thermal Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Test command
nsh> cat /proc/thermal/cpu-thermal
Trips
/* Copy from drivers/thermal/thermal_dummy.c */
{.name = "cpu_crit", .temp = 90, .hyst = 5, .type = THERMAL_CRITICAL},
{.name = "cpu_alert1", .temp = 70, .hyst = 5, .type = THERMAL_HOT},
{.name = "cpu_alert0", .temp = 60, .hyst = 5, .type = THERMAL_NORMAL},
Without this patch
# Error occured when temperature jump to 69.
z:cpu-thermal t:67 t:1 h:16 l:0 c:fan0 s:0|(invalid)
z:cpu-thermal t:72 t:1 h:16 l:0 c:fan0 s:1|1
z:cpu-thermal t:69 t:1 h:16 l:0 c:fan0 s:0|0
z:cpu-thermal t:74 t:1 h:16 l:0 c:fan0 s:1|1
With this patch
z:cpu-thermal t:67 t:1 h:16 l:0 c:fan0 s:0|(invalid)
z:cpu-thermal t:72 t:1 h:16 l:0 c:fan0 s:1|1
z:cpu-thermal t:69 t:1 h:16 l:0 c:fan0 s:1|1
z:cpu-thermal t:74 t:1 h:16 l:0 c:fan0 s:2|2
Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
sim:thermal.UINT_MAXdirectly.sim:thermal, make it eaiser to input repeat commands.Details can be found in commit message if need.
Impact
drivers/thermal
Testing