-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update substrate-sdk to version 1.7.0 #977
deps: update substrate-sdk to version 1.7.0 #977
Conversation
Updating dependencies in Cargo.dev.toml since the crates have been updated in crates.io. |
@xlc Could you have a look at the changes? Thank you in advance :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #977 +/- ##
==========================================
- Coverage 85.27% 85.25% -0.02%
==========================================
Files 87 87
Lines 10395 10350 -45
==========================================
- Hits 8864 8824 -40
+ Misses 1531 1526 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to leave upgrade to XCM v4 on a separate PR and I prefer only upgrade to it when it is thoroughly tested (e.g. when it is used by system parachains on testnets). There were enough bugs on v3 upgrades and we shouldn't take lightly on upgrading to v4.
Not sure it will be possible to not upgrade to XCM v4 since More info: paritytech/polkadot-sdk#3214 I think the only breaking change regarding the SCALE encoding is the |
I will say it will be a major regression in polkadot-sdk if we are forced to use xcm v4 and if that’s actually the case, we need polkadot-sdk to be patched first. |
… v4 Location" This reverts commit 38f45f2.
with paritytech/polkadot-sdk#3328 we won't get 100% compatibility between v4 types and v3 types |
Update polkadot-sdk to version 1.7.0
Includes many xcm changes, which were introduced in paritytech/polkadot-sdk#1230.
To reduce the amount of breaking changes I did not remove the
multi
prefix from extrinsics in thextokens
pallet:I tested the changes against https://github.com/paritytech/polkadot-sdk/tree/release-polkadot-v1.7.0