Implement dynamic field serialization on endpoints that lack it #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 5, 2023 12:38
inherited from both DFMS and HMS, as well as classes that only inherited from HMS, in order to provide dynamic field serialization on those classes.
This reverts commit 70a19d7.
inherited from both DFMS and HMS, as well as classes that only inherited from HMS, in order to provide dynamic field serialization on those classes. Subrace is left out due to a bug in the DFHMS, which will be fixed in the following commit.
augustjohnson
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to fix #300, changed
CharClassSerializer(as well as other serializers that do not currently support dynamic field serialization) to inherit fromDynamicFieldsModelSerializer. Did so by creating an abstract base class calledDynamicFieldsHyperlinkedModelSerializer(hate how long that name is, but it is technically the most correct name for it) that inherits from bothDynamicFieldsModelSerializerandserializers.HyperlinkedModelSerializerand modified all serializer classes that inherited from both of those classes individually, as well as all serializers that inherited from onlyserializers.HyperlinkedModelSerializerto inherit from this new abstract class.As a part of this change, also modifed
DynamicFieldsModelSerializerto use the lineinstead of
as the latter caused a bug when the
SubraceSerializerinherited from the DFMS, asSubraceSerializercan be called from withinRaceSerializer, in which case therequestkey does not exist, and an error is thrown.