Fix double conversion of assumed values in ADL1.4 conversion #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
============================================
+ Coverage 70.01% 70.02% +0.01%
- Complexity 6286 6287 +1
============================================
Files 627 627
Lines 21222 21217 -5
Branches 3404 3403 -1
============================================
- Hits 14858 14857 -1
+ Misses 4763 4761 -2
+ Partials 1601 1599 -2
Continue to review full report at Codecov.
|
pieterbos
approved these changes
May 17, 2021
| CAttribute cAttribute = archetype.itemAtPath("/data[id2]/events[id3]/state[id14]/items[id15]/value[id9004]/defining_code"); | ||
| CTerminologyCode cTerminologyCode = (CTerminologyCode) cAttribute.getChildren().get(0); | ||
|
|
||
| assertNull(cTerminologyCode.getAssumedValue().getTerminologyId()); |
There was a problem hiding this comment.
according to https://specifications.openehr.org/releases/BASE/latest/foundation_types.html#_terminology_code_class this must have a value. The correct one would be "local".
I created a separate issue for that, #309, since I do not think it's a good idea to solve this in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assumed values were sometimes double converted in the ADL1.4 -> ADL2 conversion, resulting in invalid archetypes. This PR removes one of those conversions and adds a test.