1680: Improve error when exporting through an account_link

openHPI · Jan 29, 2025 · a4f52e5 · a4f52e5
1 parent fed3b13
commit a4f52e5
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 1 deletion.
diff --git a/app/services/exercise_service/push_external.rb b/app/services/exercise_service/push_external.rb
@@ -18,7 +18,11 @@ def execute
           request.body = body
         end
 
-        response.success? ? nil : response.body
+        if response.success?
+          nil
+        else
+          response.status == 401 ? I18n.t('exercises.export_codeharbor.not_authorized') : response.body
+        end
       rescue StandardError => e
         e.message
       end

diff --git a/config/locales/de/exercise.yml b/config/locales/de/exercise.yml
@@ -102,6 +102,7 @@ de:
       error: Es ist ein Fehler bei der Kommunikation mit CodeHarbor aufgetreten.
       export_failed: 'Export ist fehlgeschlagen.<br>ID: %{id}<br>Title: %{title}<br><br>Error: %{error}'
       label: Zu CodeHarbor exportieren
+      not_authorized: Die Autorisierung mit CodeHarbor konnte nicht hergestellt werden. Ist der API-Schlüssel korrekt?
       successfully_exported: 'Aufgabe wurde erfolgreich exportiert.<br>ID: %{id}<br>Title: %{title}'
     external_users:
       statistics:

diff --git a/config/locales/en/exercise.yml b/config/locales/en/exercise.yml
@@ -102,6 +102,7 @@ en:
       error: An error occurred while contacting CodeHarbor
       export_failed: 'Export has failed.<br>ID: %{id}<br>Title: %{title}<br><br>Error: %{error}'
       label: Export to CodeHarbor
+      not_authorized: Authorization with could not be established with CodeHarbor. Is the API Key correct?
       successfully_exported: 'Exercise has been successfully exported.<br>ID: %{id}<br>Title: %{title}'
     external_users:
       statistics:

diff --git a/spec/services/exercise_service/push_external_spec.rb b/spec/services/exercise_service/push_external_spec.rb
@@ -53,6 +53,13 @@
 
         it { is_expected.to be response }
       end
+
+      context 'when response status is 401' do
+        let(:status) { 401 }
+        let(:response) { I18n.t('exercises.export_codeharbor.not_authorized') }
+
+        it { is_expected.to eql response }
+      end
     end
 
     context 'when an error occurs' do