Skip to content

Remove additional occurrences of TestrunExecutionEnvironment #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion app/controllers/submissions_controller.rb
Original file line number Diff line number Diff line change
@@ -439,7 +439,6 @@ def save_testrun_output(cause)
waiting_for_container_time: @testrun[:waiting_for_container_time]
)
TestrunMessage.create_for(testrun, @testrun[:messages])
TestrunExecutionEnvironment.create(testrun:, execution_environment: @submission.used_execution_environment)
end

def send_hints(tubesock, errors)
3 changes: 0 additions & 3 deletions app/models/submission.rb
Original file line number Diff line number Diff line change
@@ -48,8 +48,6 @@ class Submission < ApplicationRecord

validates :cause, inclusion: {in: CAUSES}

attr_reader :used_execution_environment

# after_save :trigger_working_times_action_cable

def collect_files
@@ -287,7 +285,6 @@ def score_file(output, file, requesting_user)
waiting_for_container_time: output[:waiting_for_container_time]
)
TestrunMessage.create_for(testrun, output[:messages])
TestrunExecutionEnvironment.create(testrun:, execution_environment: @used_execution_environment)

filename = file.filepath