Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve file filtering for submission execution #2596

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Conversation

MrSerth
Copy link
Member

@MrSerth MrSerth commented Oct 13, 2024

Previously, many different executions got all files despite not necessary needed. We now extend the file filtering to apply for submit actions, remote evaluations and test executions, too.

Previously, many different executions got all files despite not necessary needed. We now extend the file filtering to apply for submit actions, remote evaluations and test executions, too.
@MrSerth MrSerth added enhancement ruby Pull requests that update Ruby code labels Oct 13, 2024
@MrSerth MrSerth requested a review from Dome-GER October 13, 2024 20:53
@MrSerth MrSerth self-assigned this Oct 13, 2024
Copy link
Member

@Dome-GER Dome-GER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...and you've implicitly changed the check for 'run' as well. ;)

@MrSerth
Copy link
Member Author

MrSerth commented Oct 15, 2024

...and you've implicitly changed the check for 'run' as well. ;)

Indeed, because we're now keeping teacher-defined assessments if they are visible to learners 👍

@MrSerth MrSerth merged commit 57a8058 into master Oct 15, 2024
9 of 10 checks passed
@MrSerth MrSerth deleted the files_filter branch October 15, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants