Fixed #2442 :When Recent Transactions is opened without connection of internet… #2444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PratyushSingh07 pls review it |
|
LGTM , we can merge this @therajanmaurya |
|
Resolve the conflicts. |
|
can i take solve this issue @PratayushSingh07 |
This pull request currently contains some merge conflicts. Once the author, @kmanikanta335 , resolves these conflicts, we'll proceed with merging it into our codebase |
|
@therajanmaurya I resolved merge conflicts |
PratyushSingh07
requested changes
Jan 2, 2024
There was a problem hiding this comment.
Hi @kmanikanta335 , I noticed you made some changes to the code by adding two new blank lines which is a bit weird because when you remove those 2 lines you will get the orignal code
| @@ -93,6 +93,7 @@ class RecentTransactionsFragment : BaseFragment(), OnRefreshListener { | |||
|
|
|||
| RecentTransactionUiState.Initial -> {} | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
this is the 1st blank space
| @@ -30,6 +30,7 @@ class RecentTransactionViewModel @Inject constructor(private val recentTransacti | |||
|
|
|||
| private fun loadRecentTransactions(offset: Int, limit: Int) { | |||
| viewModelScope.launch { | |||
|
|
|||
There was a problem hiding this comment.
this is the 2nd blank space
…ion of internet…
…ion of internet…
…ion of internet…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2442
Screenshots of UI changes.
2442.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
✅ Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.✅ Run the unit tests with
./gradlew checkto make sure you didn't break anything✅ If you have multiple commits please combine them into one commit by squashing them.