Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #2448 Handle network error in HomeViewModel to emit error event #2449

Merged
merged 1 commit into from Jan 5, 2024
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 8, 2023

Fixes #2448

Screen_recording_20231208_203510.mp4

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

@ghost
Copy link
Author

ghost commented Dec 8, 2023

@PratyushSingh07 Can you review this...

@PratyushSingh07
Copy link
Collaborator

In the video that you have attached I see that the snackbar still appears twice before it eventually stops. Is this the supposed behaviour? I mean it should have just appeared once , isn't?

@ghost
Copy link
Author

ghost commented Dec 9, 2023

@PratyushSingh07 Two Snack bars were one for the failed to fetch client another for Accounts if you want me to remove of them i can...

@PratyushSingh07
Copy link
Collaborator

@PratyushSingh07 Two Snack bars were one for the failed to fetch client another for Accounts if you want me to remove of them i can...

Hmm, Well ideally we should also show "No internet connection" in our snackbar. So i think we can show 2 snackbars. The first one that says no internet connection(We may have a string already defined for this.) & the other say that says failed to fetch accounts

@ghost
Copy link
Author

ghost commented Dec 31, 2023

@PratyushSingh07 Made the requested changes..!

Copy link
Collaborator

@PratyushSingh07 PratyushSingh07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make sure to format your code with ctrl+shift+L if you haven't already @Thanush66

@ghost ghost requested a review from PratyushSingh07 January 2, 2024 01:55
Copy link
Collaborator

@PratyushSingh07 PratyushSingh07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therajanmaurya therajanmaurya merged commit 212a23c into openMF:development Jan 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue : the Failed to fetch details dialogue appears constantly multiple times
3 participants