Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #1861 Update dependencies versions and make necessary changes afterwards #2468

Closed
wants to merge 3 commits into from
Closed

Conversation

Maan-Sharma
Copy link

@Maan-Sharma Maan-Sharma commented Jan 2, 2024

Fixes #1861
*Dependency Updates:
Updated testing dependencies, including JUnit, Mockito Core, Mockito Android, Espresso-contrib, and androidx.annotation, to their specified versions.
Upgraded the Hilt library to version 2.50.
Updated various other dependencies in the project, such as Dagger Hilt, Kotlin, support libraries, Firebase, and Android Gradle Plugin.

*Code Modifications:
Improved MediaType creation in RetrofitUtils.kt using the toMediaTypeOrNull extension function.
Enhanced header handling in SelfServiceInterceptor.kt by using toString() for token and tenant values.
Improved MediaType creation in GuarantorRepositoryImp.kt using the toMediaTypeOrNull extension function.
Made adjustments in HomeActivity.kt related to error dialog display for Play Services.
Enhanced map initialization in LocationsFragment.kt using MapsInitializer.

*Gradle File Updates:
Updated various versions in the project's build.gradle, including support libraries, Dagger Hilt, Kotlin, JUnit, Mockito, Espresso, and others.

*Notes:
Thoroughly test the application to ensure compatibility and stability.
Keep track of the changes for documentation and future reference.
These changes aim to enhance the project by adopting newer versions of dependencies, improving code readability, and ensuring compatibility across libraries.

@PratyushSingh07
Copy link
Collaborator

follow our contribution guidelines @Maan-Sharma

@Maan-Sharma
Copy link
Author

@PratyushSingh07 I am so sorry ,I didn't write any summary. Have I make PR again or what i do next?

@PratyushSingh07
Copy link
Collaborator

well to edit PR description you can simply click on the 3 horizontals dots . But to change the commit message you will have to use git commit --amend command. For more details refer this 1 or 2

Both the links are essentially the same , there is just a slight variation : )

@Maan-Sharma
Copy link
Author

@PratyushSingh07 sir, hava a look on PR description.

@PratyushSingh07
Copy link
Collaborator

PratyushSingh07 commented Jan 3, 2024

PR description is decent, change the commit message as well and then I'll approve your PR

Also don't call me sir . Pratyush is just fine

@Maan-Sharma
Copy link
Author

Maan-Sharma commented Jan 3, 2024

@PratyushSingh07
now it is ok?

@Maan-Sharma Maan-Sharma changed the title Update dependencies versions and make neccessary changes afterwards fix #1861 chore: #1861 Update dependencies versions and make necessary changes afterwards Jan 3, 2024
@PratyushSingh07
Copy link
Collaborator

Yeah the message is fine but now you will have to merge your commits into one

@Maan-Sharma
Copy link
Author

Maan-Sharma commented Jan 3, 2024

@PratyushSingh07 in my device is build successfully then why Some checks were not successful

@Maan-Sharma
Copy link
Author

Screenshot 2024-01-03 232457

@Maan-Sharma
Copy link
Author

@PratyushSingh07 can i make this pr again , its soo messed now

@PratyushSingh07
Copy link
Collaborator

Yes you can open another PR. However I feel that updating any dependency right now isn't feasible. Updating a Dependency may start a chain reaction and before you realize you may end up changing a whole lot of code which in my opinion is never ideal.

As a developer I think we should update any dependencies only when needed. This was another reason that provoked us to discontinue the dependabot and renovate bot.

@Maan-Sharma
Copy link
Author

ok then

@Maan-Sharma Maan-Sharma closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies versions and make neccessary changes afterwards
2 participants