-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: #1861 Update dependencies versions and make necessary changes afterwards #2468
Conversation
follow our contribution guidelines @Maan-Sharma |
@PratyushSingh07 I am so sorry ,I didn't write any summary. Have I make PR again or what i do next? |
@PratyushSingh07 sir, hava a look on PR description. |
PR description is decent, change the commit message as well and then I'll approve your PR Also don't call me sir . Pratyush is just fine |
@PratyushSingh07 |
Yeah the message is fine but now you will have to merge your commits into one |
@PratyushSingh07 in my device is build successfully then why Some checks were not successful |
@PratyushSingh07 can i make this pr again , its soo messed now |
Yes you can open another PR. However I feel that updating any dependency right now isn't feasible. Updating a Dependency may start a chain reaction and before you realize you may end up changing a whole lot of code which in my opinion is never ideal. As a developer I think we should update any dependencies only when needed. This was another reason that provoked us to discontinue the dependabot and renovate bot. |
ok then |
Fixes #1861
*Dependency Updates:
Updated testing dependencies, including JUnit, Mockito Core, Mockito Android, Espresso-contrib, and androidx.annotation, to their specified versions.
Upgraded the Hilt library to version 2.50.
Updated various other dependencies in the project, such as Dagger Hilt, Kotlin, support libraries, Firebase, and Android Gradle Plugin.
*Code Modifications:
Improved MediaType creation in RetrofitUtils.kt using the toMediaTypeOrNull extension function.
Enhanced header handling in SelfServiceInterceptor.kt by using toString() for token and tenant values.
Improved MediaType creation in GuarantorRepositoryImp.kt using the toMediaTypeOrNull extension function.
Made adjustments in HomeActivity.kt related to error dialog display for Play Services.
Enhanced map initialization in LocationsFragment.kt using MapsInitializer.
*Gradle File Updates:
Updated various versions in the project's build.gradle, including support libraries, Dagger Hilt, Kotlin, JUnit, Mockito, Espresso, and others.
*Notes:
Thoroughly test the application to ensure compatibility and stability.
Keep track of the changes for documentation and future reference.
These changes aim to enhance the project by adopting newer versions of dependencies, improving code readability, and ensuring compatibility across libraries.