feat(feature:account): set up initial directory structure for account… #2773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… modules - Created directory structures for `account`, `savings-account`, `loan-account`, and `share-account` modules. - Added initial `build.gradle.kts` files and configured dependencies for each module. - Prepared `account` module to include other modules as dependencies for future integration.
|
@niyajali this is how the structure looks like. If you approve then kindly merge so I work on other modules. 
|
|
@HekmatullahAmin I don't think this module contains any viewModels, no issues merging this for now we'll refactor later |
|
@HekmatullahAmin go ahead work on other modules, this PR will be merged soon |
maybe I just added like that if i see nothings is needed i will delete it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… modules
account,savings-account,loan-account, andshare-accountmodules.build.gradle.ktsfiles and configured dependencies for each module.accountmodule to include other modules as dependencies for future integration.Fixes - Jira-#186
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.