Fix incorrect type used for retrieveOffices response in CreateClosure#53
Open
khushisahu476 wants to merge 1 commit intoopenMF:devfrom
Open
Fix incorrect type used for retrieveOffices response in CreateClosure#53khushisahu476 wants to merge 1 commit intoopenMF:devfrom
khushisahu476 wants to merge 1 commit intoopenMF:devfrom
Conversation
Author
|
Hi! This is my first contribution to this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The retrieveOffices endpoint returns an array of OfficeData objects,
but the state was previously typed as GetOfficesResponse[].
This caused TypeScript mismatches and potential runtime issues.
Updated the state type to OfficeData[] and aligned the API response
handling accordingly.
No breaking changes introduced.
Related issues and discussion
Addresses the item in ISSUES.md:
Admin Organization → /organization/offices
GetOfficesResponse missing parentName
Screenshots, if any
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
CONTRIBUTING.md.