Skip to content

fix(openapfix(openapi): add isSelfServiceUser to GetUsersResponse and GetUsersUserIdResponsei): add isSelfServiceUser to GetUsersResponse and GetUsersU…#88

Open
deepthikolipaka wants to merge 1 commit intoopenMF:devfrom
deepthikolipaka:fix/openapi-add-isSelfServiceUser
Open

fix(openapfix(openapi): add isSelfServiceUser to GetUsersResponse and GetUsersUserIdResponsei): add isSelfServiceUser to GetUsersResponse and GetUsersU…#88
deepthikolipaka wants to merge 1 commit intoopenMF:devfrom
deepthikolipaka:fix/openapi-add-isSelfServiceUser

Conversation

@deepthikolipaka
Copy link

@deepthikolipaka deepthikolipaka commented Mar 16, 2026

Summary

Added missing isSelfServiceUser boolean field to:

  • GetUsersResponse (used in /users endpoint)
  • GetUsersUserIdResponse (used in /users/{id} endpoint)

Problem

The isSelfServiceUser field was missing from the OpenAPI spec,
causing the generated TypeScript client to not include this field,
which is returned by the Fineract backend.

Changes

  • Added isSelfServiceUser: boolean to GetUsersResponse schema
  • Added isSelfServiceUser: boolean to GetUsersUserIdResponse schema
  • Regenerated Fineract API client

Related

Fixes item listed in ISSUES.md under Admin Users section

Summary by CodeRabbit

New Features

  • Added a self-service user indicator to user information displays. This new field appears in user lists, user details, and template responses, providing consistent identification of self-service accounts across the application.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fdc00605-f099-4983-aa0e-ffe2ba562c90

📥 Commits

Reviewing files that changed from the base of the PR and between 1d69ff7 and bc1b045.

📒 Files selected for processing (1)
  • fineract.yaml

📝 Walkthrough

Walkthrough

Added isSelfServiceUser boolean property with example value false to four user-related API response schemas (GetUsersResponse, GetUserDetailsResponse, GetUsersUserIdResponse, and GetUsersTemplateResponse) to explicitly indicate user self-service status.

Changes

Cohort / File(s) Summary
User Schema Updates
fineract.yaml
Added isSelfServiceUser: boolean property with example false to four user-related API schemas: GetUsersResponse, GetUserDetailsResponse, GetUsersUserIdResponse, and GetUsersTemplateResponse.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • gkbishnoi07

Poem

🐰 A schema so clear, with a flag shiny-new,
Self-service users, marked bright as the dew,
Four schemas adorned, each boolean true,
The API hops forward with whisker-twitching glee!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title contains a duplicated prefix and truncation artifact, making it malformed and difficult to understand despite relating to the actual changes. Revise the title to be clear and concise, such as 'fix(openapi): add isSelfServiceUser to user response schemas' or 'feat(openapi): add isSelfServiceUser field to user endpoints'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable poems in the walkthrough.

Disable the reviews.poem setting to disable the poems in the walkthrough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant