Skip to content

fix(openapi): add parentId and parentName to GetOfficesResponse#89

Open
deepthikolipaka wants to merge 1 commit intoopenMF:devfrom
deepthikolipaka:fix/openapi-add-parentName-offices
Open

fix(openapi): add parentId and parentName to GetOfficesResponse#89
deepthikolipaka wants to merge 1 commit intoopenMF:devfrom
deepthikolipaka:fix/openapi-add-parentName-offices

Conversation

@deepthikolipaka
Copy link

@deepthikolipaka deepthikolipaka commented Mar 16, 2026

Summary

Added missing fields to GetOfficesResponse schema:

  • parentId (integer)
  • parentName (string)

Problem

These fields were missing from the OpenAPI spec, causing the
Organization → Offices page to not display parent office information.

Changes

  • Added parentId and parentName to GetOfficesResponse schema

Related

Fixes item listed in ISSUES.md under Admin Organization section

Summary by CodeRabbit

  • New Features
    • Enhanced office hierarchy support with parent office tracking
    • Expanded account data models for loans, savings, and shares with more detailed financial tracking
    • Added comprehensive interest calculation and recalculation properties
    • Introduced detailed transaction and fee management structures
    • Improved scheduling and calendar management capabilities
    • Extended account linking and relationship tracking for better data organization

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f933f6ca-af9d-4136-9491-b5e731604b38

📥 Commits

Reviewing files that changed from the base of the PR and between 1d69ff7 and b92c8f9.

📒 Files selected for processing (1)
  • fineract.yaml

📝 Walkthrough

Walkthrough

The fineract.yaml schema file is expanded with numerous properties across multiple financial domain schemas. Office schemas gain parentId and parentName for hierarchical relationships, while loan, savings, share, and transaction schemas are enriched with detailed fields for interest calculations, account linkages, fees, and scheduling operations.

Changes

Cohort / File(s) Summary
Office Hierarchy
fineract.yaml (schemas: offices)
Addition of parentId (int64) and parentName (string) properties to enable parent-child office relationships.
Loan and Product Schemas
fineract.yaml (schemas: LoanProduct, loan-related request/response models)
Extension with properties for interest calculation types, compounding periods, recalculation data, and detailed loan product configuration.
Savings Account Schemas
fineract.yaml (schemas: SavingsAccount, SavingsAccountChargeData, SavingsAccountTransactionData, SavingsAccountSummaryData)
Expansion with properties for interest periods, rates, transaction details, charge data, and comprehensive account state tracking.
Interest and Recalculation Schemas
fineract.yaml (schemas: InterestPeriod, InterestRateChartSlabData, InterestRecalculationData)
New and expanded schemas defining granular interest calculation, period tracking, and recalculation configuration.
Operational and Transactional Schemas
fineract.yaml (schemas: ExternalTransferData, CalendarData, Job, Partner, Ledger)
Addition of detailed properties for schedules, transfers, on-hold funds, execution timelines, and job metadata.
Request/Response Contracts
fineract.yaml (schemas: PostLoansLoanIdRequest, PostSavingsAccountsRequest, PostRecurringDepositAccountsRequest, GetLoansLoanIdResponse, GetSavingsAccountsResponse)
Expansion of CRUD operation contracts with granular fields for account configuration, validation, and detailed responses.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐰 A yaml file bloomed with detail so fine,
Hierarchies nested, interests align,
Offices now know their parent's name,
Accounts and savings—no two the same,
Financial whiskers twitch with glee,
Schema-shaped carrots, bursting free! 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the main change: adding parentId and parentName fields to GetOfficesResponse in the OpenAPI schema.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant