Skip to content

fix(openapi): add accountNo and externalId to GetCentersPageItems#92

Open
deepthikolipaka wants to merge 1 commit intoopenMF:devfrom
deepthikolipaka:fix/openapi-add-missing-centers-fields
Open

fix(openapi): add accountNo and externalId to GetCentersPageItems#92
deepthikolipaka wants to merge 1 commit intoopenMF:devfrom
deepthikolipaka:fix/openapi-add-missing-centers-fields

Conversation

@deepthikolipaka
Copy link

@deepthikolipaka deepthikolipaka commented Mar 16, 2026

Summary

Added missing fields to GetCentersPageItems schema:

  • accountNo (string)
  • externalId (string)

Problem

These fields were missing from the OpenAPI spec, causing
the Institution Centers page to not display account number
and external ID correctly.

Changes

  • Added accountNo and externalId to GetCentersPageItems schema

Related

Fixes item listed in ISSUES.md under Institution Centers section

Summary by CodeRabbit

  • New Features
    • Added optional account number and external ID identifier fields to center API responses.

@coderabbitai
Copy link

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 652ac521-fdfc-472b-90de-befa958fbbc7

📥 Commits

Reviewing files that changed from the base of the PR and between 1d69ff7 and 9bed255.

📒 Files selected for processing (1)
  • fineract.yaml

📝 Walkthrough

Walkthrough

The change adds two optional string properties (accountNo and externalId) to the GetCentersPageItems schema in the OpenAPI specification. This is a purely additive schema enhancement that expands data model definitions without modifying API endpoints or existing logic.

Changes

Cohort / File(s) Summary
API Schema Enhancement
fineract.yaml
Added accountNo and externalId optional string properties to components.schemas.GetCentersPageItems, enabling API responses to include account numbers and external identifiers for center page items.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰✨ Two fields hop into the schema today,
AccountNo and ExternalId come to play,
Simple strings with values so bright,
Making center pages shine just right! 🌟

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding two missing fields (accountNo and externalId) to the GetCentersPageItems schema in the OpenAPI specification.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant