fix: no-op assignment before deleting allowPartialPeriodInterestCalcu…

[chris-muiru]

…lation

Description

Remove redundant no-op assignment that was immediately deleted.

Screenshots, if any

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

• [ x ] If you have multiple commits please combine them into one commit by squashing them.

• [ x ] Read and understood the contribution guidelines at web-app/.github/CONTRIBUTING.md.

Summary by CodeRabbit

• Refactor
  • Simplified loan account editing and product management payload handling by removing redundant field transformations, resulting in cleaner data submission with no impact on functionality.

[coderabbitai]

Note

.coderabbit.yaml has unrecognized properties

CodeRabbit is using all valid settings from your configuration. Unrecognized properties (listed below) have been ignored and may indicate typos or deprecated fields that can be removed.

⚠️ Parsing warnings (1)

Validation error: Unrecognized key(s) in object: 'pre_merge_checks'

⚙️ Configuration instructions

• Please see the configuration documentation for more information.
• You can also validate your configuration using the online YAML validator.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Walkthrough

Removes workaround code that duplicated the allowPartialPeriodInterestCalculation field to itself and then deleted the original across three files. The field is now handled directly without this intermediate aliasing step.

Changes

Cohort / File(s)	Summary
allowPartialPeriodInterestCalculation Workaround Removal src/app/loans/edit-loans-account/edit-loans-account.component.ts, src/app/loans/loans.service.ts, src/app/products/loan-products/loan-products.ts	Removed the aliasing workaround that copied allowPartialPeriodInterestCalculation to itself and deleted the original field. The field is now passed through directly in payload construction. Import order adjusted in loans.service.ts.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

• Fix typo allowPartialPeriodInterestCalcualtion for allowPartialPeriodInterestCalculation #2993: Modifies the same allowPartialPeriodInterestCalculation field handling in the same files (fixes typo vs. removes workaround).

Suggested reviewers

• IOhacker
• gkbishnoi07
• alberto-art3ch

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: removing a no-op assignment to allowPartialPeriodInterestCalculation that is immediately deleted, which matches the core objective across all three modified files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into dev
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[IOhacker]

@chris-muiru please open a jira Ticket for this, and can you show the error and how it fix that error in a video please?

[chris-muiru]

This is a simple refactor to remove unused code

[IOhacker]

Hello @chris-muiru we track the changes using Jira https://mifosforge.jira.com/jira/software/c/projects/WEB/boards/62 helps with a ticket and please get involved in the #web-app Slack channel for any query.

[github-actions]

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.