WEB-657: WorkingCapital Loan approve or reject actions#3416
Open
alberto-art3ch wants to merge 1 commit intoopenMF:devfrom
Open
WEB-657: WorkingCapital Loan approve or reject actions#3416alberto-art3ch wants to merge 1 commit intoopenMF:devfrom
alberto-art3ch wants to merge 1 commit intoopenMF:devfrom
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Template label updates src/app/loans/loans-account-stepper/.../loans-account-terms-step.component.html, src/app/loans/loans-view/general-tab/general-tab.component.html |
Replaced the second label shown with labels.inputs.Volume (translated) where working-capital contexts display total payment; no control or binding changes. |
Approve loan — template & logic src/app/loans/loans-view/loan-account-actions/approve-loan/approve-loan.component.html, src/app/loans/loans-view/loan-account-actions/approve-loan/approve-loan.component.ts |
Made "Available Disbursement Amount" field conditional on isLoanProduct; removed one delinquency-data assignment; introduced loanCommand='approve', built a conditional request$ that calls loanActionButtons() for loan products or applyWorkingCapitalLoanAccountCommand() for working-capital, added unsupported-product form error and subscription error handling. |
Other loan action components src/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.ts, src/app/loans/loans-view/loan-account-actions/undo-approval/undo-approval.component.ts |
Introduced loanCommand constants ('reject', 'undoapproval') and conditional service calls: loanActionButtons() for loan products or applyWorkingCapitalLoanAccountCommand() for working-capital; navigate back on completion. |
Translations (added Volume key) src/assets/translations/cs-CS.json, src/assets/translations/de-DE.json, src/assets/translations/en-US.json, src/assets/translations/es-CL.json, src/assets/translations/es-MX.json, src/assets/translations/fr-FR.json, src/assets/translations/it-IT.json, src/assets/translations/ko-KO.json, src/assets/translations/lt-LT.json, src/assets/translations/lv-LV.json, src/assets/translations/ne-NE.json, src/assets/translations/pt-PT.json, src/assets/translations/sw-SW.json |
Added Volume translation key/value in each locale file (no other JSON changes). |
Sequence Diagram(s)
sequenceDiagram
participant UI as Approve/Reject/Undo Component
participant Auth as Auth/Caller (component state)
participant Service as LoanService
participant Router as Router
UI->>Auth: determine isLoanProduct / isWorkingCapital
alt isLoanProduct
UI->>Service: loanActionButtons(loanId, loanCommand, data)
else isWorkingCapital
UI->>Service: applyWorkingCapitalLoanAccountCommand(loanId, loanCommand, data)
else unsupported
UI-->>UI: set form error {unsupportedProductType: true} and return
end
Service-->>UI: next / success
UI->>Router: gotoLoanDefaultView()
Service-->>UI: error
UI-->>UI: set form error {submitFailed: true}
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
- WEB-813: Working Capital loan account creation #3257: Touches same loan templates and totalPayment/label rendering for working-capital vs loan products.
- WEB-455: fix alignments #2874: Modifies loans-account-terms-step component logic affecting tranche/term behavior (overlaps with template changes).
- WEB-521 fix(i18n): add missing translations and apply translate pipes across … #2934: Makes i18n and loan-view template edits similar to this PR's translation and template updates.
Suggested reviewers
- adamsaghy
- IOhacker
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title 'WEB-657: WorkingCapital Loan approve or reject actions' directly and specifically describes the main changes in the pull request—adding approve and reject functionality for WorkingCapital Loan accounts, which aligns with the modifications across component templates and service implementations. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
📝 Coding Plan
- Generate coding plan for human review comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (4)
src/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.ts (1)
89-96: Avoidanyin subscribe callbacks here as well.The callback payload is unused, so the
anyannotation can be removed for stricter typing.♻️ Proposed fix
- this.loanService.loanActionButtons(this.loanId, loanCommand, data).subscribe((response: any) => { + this.loanService.loanActionButtons(this.loanId, loanCommand, data).subscribe(() => { this.gotoLoanDefaultView(); }); @@ - .subscribe((response: any) => { + .subscribe(() => { this.gotoLoanDefaultView(); });Based on learnings: "avoid using Observable as a project-wide pattern for API responses."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.ts` around lines 89 - 96, The subscribe callbacks for loanService.loanActionButtons(...) and loanService.applyWorkingCapitalLoanAccountCommand(...) use the unused parameter typed as any; remove the unused parameter (or replace with a properly typed response type) from both subscribe handlers to avoid using any. Update the calls around loanActionButtons and applyWorkingCapitalLoanAccountCommand so the subscribe callbacks simply call gotoLoanDefaultView() with no "response: any" parameter, or substitute a concrete response type if you expect to use the payload later.src/app/loans/loans-view/loan-account-actions/undo-approval/undo-approval.component.ts (1)
49-56: Remove unnecessaryanyin subscribe callbacks.
responseis unused in both callbacks, soanycan be dropped entirely to keep typing strict.♻️ Proposed fix
- .subscribe((response: any) => { + .subscribe(() => { this.gotoLoanDefaultView(); }); @@ - .subscribe((response: any) => { + .subscribe(() => { this.gotoLoanDefaultView(); });As per coding guidelines
src/app/**/*.ts: "Use TypeScript for all application code with strict typing conventions."🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/app/loans/loans-view/loan-account-actions/undo-approval/undo-approval.component.ts` around lines 49 - 56, Remove the unnecessary unused `any` parameter from the subscribe callbacks so the handlers use no parameters (or an explicit empty parameter list) to keep typing strict; update the two subscribe calls (the one that calls this.gotoLoanDefaultView() after the initial apply command and the one on this.loanService.applyWorkingCapitalLoanAccountCommand(this.loanId, loanCommand, { note: this.note.value })) by deleting `(response: any)` and using `()` instead.src/assets/translations/ne-NE.json (1)
2720-2720: Please verify the Nepali terminology for “Volume.”Line 2720 uses
"भोल्युमेन", which looks like a transliteration and may read less naturally for Nepali users in a financial context. Please confirm with a native reviewer/localization glossary (e.g., whether"परिमाण"/"मात्रा"is preferred) to keep terminology consistent and user-friendly.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/assets/translations/ne-NE.json` at line 2720, The translation for the JSON key "Volume" currently uses the transliteration "भोल्युमेन"; verify with a native Nepali reviewer or the localization glossary whether a more natural term like "परिमाण" or "मात्रा" should be used and update the value for the "Volume" key accordingly, keeping punctuation and JSON formatting intact and ensuring consistency with related keys (e.g., any other volume/quantity labels) across the ne-NE translations.src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.html (1)
29-29: Consider using a single translation key instead of concatenating two separate translations.Concatenating two translate pipes (
'labels.inputs.Total Payment'+'labels.inputs.Volume') can cause i18n issues because word order and phrasing differ across languages. Translators also lose context when each part is translated separately.🌐 Proposed refactor for better i18n support
Create a single translation key for the complete label:
- <mat-label>{{ 'labels.inputs.Total Payment' | translate }} {{ 'labels.inputs.Volume' | translate }}</mat-label> + <mat-label>{{ 'labels.inputs.Total Payment Volume' | translate }}</mat-label>Then add the new key to all locale files:
"labels": { "inputs": { "Total Payment Volume": "Total Payment Volume" } }(Adjust the translation text appropriately for each locale.)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.html` at line 29, The template concatenates two translate pipes in the mat-label ({{ 'labels.inputs.Total Payment' | translate }} {{ 'labels.inputs.Volume' | translate }}), which breaks i18n grammar; replace the two-part translation with a single translation key (e.g., 'labels.inputs.Total Payment Volume') and update the locale files accordingly, then change the template to use just that single key in the mat-label so translators can provide correct phrasing for LoansAccountTermsStepComponent.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/app/loans/loans-view/general-tab/general-tab.component.html`:
- Around line 271-272: The label currently always renders "Total Payment
Volume"; update the template near the span that outputs {{ 'labels.inputs.Total
Payment' | translate }} and {{ 'labels.inputs.Volume' | translate }} so the
"Volume" translation is only included for Working Capital loans; wrap the Volume
part in an Angular conditional (e.g., *ngIf="isWorkingCapital(loan)" or use a
ternary in the binding checking loan.productType/loan.type ===
'WORKING_CAPITAL') and keep non-working-capital loans showing just the amount
label. Ensure you reference the component method/property (isWorkingCapital or
loan.productType/loan.type) that determines working-capital status.
In
`@src/app/loans/loans-view/loan-account-actions/approve-loan/approve-loan.component.ts`:
- Around line 120-131: Current flow silently does nothing when neither
this.isLoanProduct nor this.isWorkingCapital is true and both HTTP calls ignore
errors; update the approve path to explicitly handle unsupported product types
and surface API errors: keep the existing branches using
loanService.loanActionButtons(this.loanId, ...) and
loanService.applyWorkingCapitalLoanAccountCommand(this.loanId, ...), but add
error handlers to the subscribe (or switch to pipe + catchError) to show a
user-facing error/toast and avoid calling gotoLoanDefaultView on failure, and
add an else branch that logs/alerts an unsupported product type for the current
loanId so the no-op path is eliminated.
In `@src/assets/translations/lt-LT.json`:
- Line 2720: The translation value for the JSON key "Volume" currently reads
"Volumen" (incorrect language); update the value for the "Volume" key in the
lt-LT translation file to the correct Lithuanian term (e.g., "Tūris" or the
project-approved equivalent) so the entry becomes "Volume": "Tūris".
---
Nitpick comments:
In
`@src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.html`:
- Line 29: The template concatenates two translate pipes in the mat-label ({{
'labels.inputs.Total Payment' | translate }} {{ 'labels.inputs.Volume' |
translate }}), which breaks i18n grammar; replace the two-part translation with
a single translation key (e.g., 'labels.inputs.Total Payment Volume') and update
the locale files accordingly, then change the template to use just that single
key in the mat-label so translators can provide correct phrasing for
LoansAccountTermsStepComponent.
In
`@src/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.ts`:
- Around line 89-96: The subscribe callbacks for
loanService.loanActionButtons(...) and
loanService.applyWorkingCapitalLoanAccountCommand(...) use the unused parameter
typed as any; remove the unused parameter (or replace with a properly typed
response type) from both subscribe handlers to avoid using any. Update the calls
around loanActionButtons and applyWorkingCapitalLoanAccountCommand so the
subscribe callbacks simply call gotoLoanDefaultView() with no "response: any"
parameter, or substitute a concrete response type if you expect to use the
payload later.
In
`@src/app/loans/loans-view/loan-account-actions/undo-approval/undo-approval.component.ts`:
- Around line 49-56: Remove the unnecessary unused `any` parameter from the
subscribe callbacks so the handlers use no parameters (or an explicit empty
parameter list) to keep typing strict; update the two subscribe calls (the one
that calls this.gotoLoanDefaultView() after the initial apply command and the
one on this.loanService.applyWorkingCapitalLoanAccountCommand(this.loanId,
loanCommand, { note: this.note.value })) by deleting `(response: any)` and using
`()` instead.
In `@src/assets/translations/ne-NE.json`:
- Line 2720: The translation for the JSON key "Volume" currently uses the
transliteration "भोल्युमेन"; verify with a native Nepali reviewer or the
localization glossary whether a more natural term like "परिमाण" or "मात्रा"
should be used and update the value for the "Volume" key accordingly, keeping
punctuation and JSON formatting intact and ensuring consistency with related
keys (e.g., any other volume/quantity labels) across the ne-NE translations.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: bb5174f7-ae8a-41d3-bd23-532916a3f3a9
📒 Files selected for processing (19)
src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.htmlsrc/app/loans/loans-view/general-tab/general-tab.component.htmlsrc/app/loans/loans-view/loan-account-actions/approve-loan/approve-loan.component.htmlsrc/app/loans/loans-view/loan-account-actions/approve-loan/approve-loan.component.tssrc/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.tssrc/app/loans/loans-view/loan-account-actions/undo-approval/undo-approval.component.tssrc/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
Comment on lines
+271
to
272
| >{{ 'labels.inputs.Total Payment' | translate }} {{ 'labels.inputs.Volume' | translate }}:</span | ||
| > |
There was a problem hiding this comment.
Scope “Volume” label to Working Capital loans only.
Line 271 currently shows “Total Payment Volume” for every loan in this view. This should be conditional; non-working-capital loans should keep the amount label.
Proposed fix
- <span class="flex-50"
- >{{ 'labels.inputs.Total Payment' | translate }} {{ 'labels.inputs.Volume' | translate }}:</span
- >
+ <span class="flex-50">
+ {{ 'labels.inputs.Total Payment' | translate }}
+ {{
+ (loanProductType() === 'labels.catalogs.Working Capital'
+ ? ('labels.inputs.Volume' | translate)
+ : ('labels.inputs.Amount' | translate))
+ }}:
+ </span>🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@src/app/loans/loans-view/general-tab/general-tab.component.html` around lines
271 - 272, The label currently always renders "Total Payment Volume"; update the
template near the span that outputs {{ 'labels.inputs.Total Payment' | translate
}} and {{ 'labels.inputs.Volume' | translate }} so the "Volume" translation is
only included for Working Capital loans; wrap the Volume part in an Angular
conditional (e.g., *ngIf="isWorkingCapital(loan)" or use a ternary in the
binding checking loan.productType/loan.type === 'WORKING_CAPITAL') and keep
non-working-capital loans showing just the amount label. Ensure you reference
the component method/property (isWorkingCapital or loan.productType/loan.type)
that determines working-capital status.
src/app/loans/loans-view/loan-account-actions/approve-loan/approve-loan.component.ts
Show resolved
Hide resolved
alberto-art3ch
force-pushed
the
WEB-657/workingcapital-loan-approve-reject
branch
from
b5ef8b1 to
d0af128
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.ts (1)
31-36: Consider stronger typing for the form.The component uses
UntypedFormGroupandUntypedFormBuilder. While this is functional, migrating to strictly-typed reactive forms (FormGroup<T>) would improve type safety and align with Angular's modern patterns.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.ts` around lines 31 - 36, The component currently uses UntypedFormBuilder and UntypedFormGroup (see RejectLoanComponent, formBuilder, and rejectLoanForm); change these to typed reactive forms by replacing UntypedFormBuilder with FormBuilder and define rejectLoanForm as FormGroup<YourFormType> (create an interface/type describing form controls and their value types), update any form creation calls in RejectLoanComponent to use this type (e.g., this.formBuilder.group<YourFormType>(...)) and adjust usages of controls to use the typed keys so callers (value access, get, patchValue) benefit from compile-time checks.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In
`@src/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.ts`:
- Around line 87-98: The submission path for reject action lacks error handling,
silently no-ops when neither isLoanProduct nor isWorkingCapital is true, and
uses an unused any-typed response; update the method to: call
loanService.loanActionButtons(...) and
applyWorkingCapitalLoanAccountCommand(...) with subscribe handlers that handle
both next and error (on success call gotoLoanDefaultView(), on error log and
surface a user-facing message via the app's toast/snackbar service), remove or
replace the unused (response: any) with a concrete response type per API
contracts (or omit the param if unused), and add an else branch that logs/alerts
when no product type matches (or disables the action) to avoid silent no-op;
reference the existing symbols loanActionButtons,
applyWorkingCapitalLoanAccountCommand, gotoLoanDefaultView, isLoanProduct, and
isWorkingCapital when making changes.
---
Nitpick comments:
In
`@src/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.ts`:
- Around line 31-36: The component currently uses UntypedFormBuilder and
UntypedFormGroup (see RejectLoanComponent, formBuilder, and rejectLoanForm);
change these to typed reactive forms by replacing UntypedFormBuilder with
FormBuilder and define rejectLoanForm as FormGroup<YourFormType> (create an
interface/type describing form controls and their value types), update any form
creation calls in RejectLoanComponent to use this type (e.g.,
this.formBuilder.group<YourFormType>(...)) and adjust usages of controls to use
the typed keys so callers (value access, get, patchValue) benefit from
compile-time checks.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 6e75c5b8-033a-4f8e-940a-372da6a577bb
📒 Files selected for processing (19)
src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.htmlsrc/app/loans/loans-view/general-tab/general-tab.component.htmlsrc/app/loans/loans-view/loan-account-actions/approve-loan/approve-loan.component.htmlsrc/app/loans/loans-view/loan-account-actions/approve-loan/approve-loan.component.tssrc/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.tssrc/app/loans/loans-view/loan-account-actions/undo-approval/undo-approval.component.tssrc/assets/translations/cs-CS.jsonsrc/assets/translations/de-DE.jsonsrc/assets/translations/en-US.jsonsrc/assets/translations/es-CL.jsonsrc/assets/translations/es-MX.jsonsrc/assets/translations/fr-FR.jsonsrc/assets/translations/it-IT.jsonsrc/assets/translations/ko-KO.jsonsrc/assets/translations/lt-LT.jsonsrc/assets/translations/lv-LV.jsonsrc/assets/translations/ne-NE.jsonsrc/assets/translations/pt-PT.jsonsrc/assets/translations/sw-SW.json
✅ Files skipped from review due to trivial changes (15)
- src/app/loans/loans-view/loan-account-actions/approve-loan/approve-loan.component.html
- src/app/loans/loans-view/general-tab/general-tab.component.html
- src/assets/translations/es-CL.json
- src/assets/translations/ko-KO.json
- src/assets/translations/en-US.json
- src/assets/translations/fr-FR.json
- src/assets/translations/lt-LT.json
- src/app/loans/loans-account-stepper/loans-account-terms-step/loans-account-terms-step.component.html
- src/assets/translations/es-MX.json
- src/assets/translations/it-IT.json
- src/assets/translations/de-DE.json
- src/assets/translations/sw-SW.json
- src/assets/translations/ne-NE.json
- src/assets/translations/lv-LV.json
- src/assets/translations/pt-PT.json
🚧 Files skipped from review as they are similar to previous changes (3)
- src/app/loans/loans-view/loan-account-actions/undo-approval/undo-approval.component.ts
- src/app/loans/loans-view/loan-account-actions/approve-loan/approve-loan.component.ts
- src/assets/translations/cs-CS.json
Comment on lines
+87
to
98
| const loanCommand: string = 'reject'; | ||
| if (this.isLoanProduct) { | ||
| this.loanService.loanActionButtons(this.loanId, 'reject', data).subscribe((response: any) => { | ||
| this.loanService.loanActionButtons(this.loanId, loanCommand, data).subscribe((response: any) => { | ||
| this.gotoLoanDefaultView(); | ||
| }); | ||
| } else if (this.isWorkingCapital) { | ||
| this.loanService | ||
| .applyWorkingCapitalLoanAccountCommand(this.loanId, loanCommand, data) | ||
| .subscribe((response: any) => { | ||
| this.gotoLoanDefaultView(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
Add error handling and consider edge case coverage.
Several concerns with this submission logic:
- No error handling: If the API call fails, users receive no feedback and the UI state becomes inconsistent.
- Unused
responseparameter: Theresponseis typed but never used—either remove it or add proper typing per project conventions. - Silent no-op: If neither
isLoanProductnorisWorkingCapitalis true, the method silently does nothing.
Proposed fix with error handling
const loanCommand: string = 'reject';
if (this.isLoanProduct) {
- this.loanService.loanActionButtons(this.loanId, loanCommand, data).subscribe((response: any) => {
- this.gotoLoanDefaultView();
- });
+ this.loanService.loanActionButtons(this.loanId, loanCommand, data).subscribe({
+ next: () => this.gotoLoanDefaultView(),
+ error: (err) => console.error('Failed to reject loan', err)
+ });
} else if (this.isWorkingCapital) {
- this.loanService
- .applyWorkingCapitalLoanAccountCommand(this.loanId, loanCommand, data)
- .subscribe((response: any) => {
- this.gotoLoanDefaultView();
- });
+ this.loanService
+ .applyWorkingCapitalLoanAccountCommand(this.loanId, loanCommand, data)
+ .subscribe({
+ next: () => this.gotoLoanDefaultView(),
+ error: (err) => console.error('Failed to reject working capital loan', err)
+ });
+ } else {
+ console.warn('Unknown loan product type; reject action not performed');
}Consider also showing a user-facing error notification (e.g., via a toast/snackbar service) rather than just logging to console. Based on learnings: avoid Observable<any> and introduce specific types for API responses as a cross-cutting refactor.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In
`@src/app/loans/loans-view/loan-account-actions/reject-loan/reject-loan.component.ts`
around lines 87 - 98, The submission path for reject action lacks error
handling, silently no-ops when neither isLoanProduct nor isWorkingCapital is
true, and uses an unused any-typed response; update the method to: call
loanService.loanActionButtons(...) and
applyWorkingCapitalLoanAccountCommand(...) with subscribe handlers that handle
both next and error (on success call gotoLoanDefaultView(), on error log and
surface a user-facing message via the app's toast/snackbar service), remove or
replace the unused (response: any) with a concrete response type per API
contracts (or omit the param if unused), and add an else branch that logs/alerts
when no product type matches (or disables the action) to avoid silent no-op;
reference the existing symbols loanActionButtons,
applyWorkingCapitalLoanAccountCommand, gotoLoanDefaultView, isLoanProduct, and
isWorkingCapital when making changes.
alberto-art3ch
force-pushed
the
WEB-657/workingcapital-loan-approve-reject
branch
from
d0af128 to
caf14f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that we have the WorkingCapital Loan account creation we need to approve or reject the account
WEB-657
Screenshots
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
If you have multiple commits please combine them into one commit by squashing them.
Read and understood the contribution guidelines at
web-app/.github/CONTRIBUTING.md.Summary by CodeRabbit
New Features
UI/UX Updates
Localization