CI Tests for Dnf5 support #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openSUSE's dnf5 package adds /etc/dnf/repos.d to the default repo directory list. So this makes cnf search that as well.
This gives an error if it can't detect a supported package manager.
This just makes the examples in the documentation match the current output format.
The man page also instructs you on how to update the repository chache that is queried.
This also modifies the zsh file to use the COMMAND_NOT_FOUND_BIN variable, just like the bash one.
This mentions that cnf support is already included in fish. It also adds a command_not_found.fish script, but you only need to use that if: command-not-found is not in your path, or not the one you want to use fish has detected another command not found handler, and prefers that Note that overriding the command not found behaviour is only avilable since fish version 1.23.1.
This enables manually trigger the "PR check" workflow from the github.com web interface, thus allowing people to easilly run the workflow before actually submitting a pull request.
The Dockerfile is also renamed to zypper.dockerfile. This is in preparation for having multiple docker images.
This also builds a new docker image with dnf5 installed, but no zypper. The README is also updated on how to manually build the images and run the tests. The bats submodule is also updated to v1.11.0, as that version introduces a "bats_test_function" to dynamically register test functions.
Merged
vyskocilm
approved these changes
Aug 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds CI Tests for for Dnf5: these reuse all the tests for zypper by using a for loop and bat's new ``bats_test_function
feature. However the script used to generate the docker file is new, but tries to do the same thing as thezypper` one (but with `dnf5` of course).This pull request depends on some of the changes made by my previous two: #34 and #35, so only the last three listed commits are new.
Interestingly, I found a bug in openSUSE Tumbleweed's repo:
dnf5seams to depend somehow on eitherlibcurl4orlibcurl.so.4()(64bit). These capabilities are provided by both thelibcurl-mini4andlibcurl4packages. However with the former installed,dnf5complains:The same issue happens with the old
dnf.I haven't the faintest clue who to report this problem to though.