Fail fast on empty openai-api-key to prevent misleading server-info ENOENT#71
Open
topherbuckley wants to merge 1 commit intoopenai:mainfrom
Open
Fail fast on empty openai-api-key to prevent misleading server-info ENOENT#71topherbuckley wants to merge 1 commit intoopenai:mainfrom
topherbuckley wants to merge 1 commit intoopenai:mainfrom
Conversation
Root cause: the Read server info step was allowed to run when a prompt was provided even if openai-api-key was empty, which skipped proxy startup and later failed with a misleading ENOENT while reading <run_id>.json. Fix: add an explicit preflight validation step (for prompt runs) that trims openai-api-key and fails fast with a clear actionable error when empty; and gate Read server info on openai-api-key presence so downstream read logic cannot run on invalid startup paths. Behavior: valid-key flows remain unchanged; missing/blank key now fails early with a clear message instead of a missing server-info JSON error.
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #70 by adding explicit preflight validation for openai-api-key and preventing downstream server-info
reads when proxy startup cannot occur.
Root cause
Read server info could run when prompt/prompt-file was set even if openai-api-key was empty. In that case, proxy
startup was skipped, no <run_id>.json was created, and the action later failed with a misleading ENOENT error.
Fix
Before / After
run on invalid startup paths.
Scope
Minimal, focused change in action.yml only.