Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2b012624ce
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
92d239d to
e6f78d1
Compare
8cc6c06 to
deee4fd
Compare
jif-oai
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
zsh-forksessions routed through unified-exec need fd-safe process launch semantics so escalation works reliably for long-lived PTY sessions.This commit fixes fd handling at each handoff boundary, including a subtle spawn-error path where aggressive fd pruning could hide
execfailures.What Changed
shell-escalation(shell-escalation/src/unix/escalate_client.rs):stdin/stdout/stderrbefore sending fds to the server0/1/2) inSuperExecMessagewhile transferring the duplicated fdsSpawnLifecycle::inherited_fds()incore/src/unified_exec/process.rscore/src/unified_exec/process_manager.rs)core/src/tools/runtimes/shell/zsh_fork_backend.rs)utils/pty/src/pty.rsviaspawn_process_with_inherited_fds(...).utils/pty/src/pty.rsto not closeFD_CLOEXECdescriptors, preserving Rust's internal exec-error pipe so missing executables still fail atspawn().utils/pty/src/tests.rsfor:Verification
cargo clippy -p codex-utils-pty --tests -- -D warningscargo test -p codex-utils-ptycargo test -p codex-shell-escalationStack created with Sapling. Best reviewed with ReviewStack.