Add tool call arguments in ToolContext for RunHooks #1765
Merged
+74
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seratch
approved these changes
Sep 22, 2025
|
Thanks for the suggestion. I agree this is safer for us to accept than #253; @rm-openai let me know if you have any comments before I merge this within a few business days. |
rm-openai
reviewed
Sep 22, 2025
src/agents/tool_context.py
Outdated
| tool_call_id: str = field(default_factory=_assert_must_pass_tool_call_id) | ||
| """The ID of the tool call.""" | ||
|
|
||
| tool_arguments: Optional[str] = None |
There was a problem hiding this comment.
can you make this non-optional, similar to tool_call_id above?
There was a problem hiding this comment.
No problem, but this will require changes in quite a few test cases, since ToolContext will now always need to be passed a tool_arguments.
There was a problem hiding this comment.
Done. I also updated realtime/session.py where ToolContext needs tool_arguments too.
seratch
added a commit
to openai/openai-agents-js
that referenced
this pull request
Sep 26, 2025
seratch
added a commit
to openai/openai-agents-js
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Currently, the
RunHookslifecycle (on_tool_start,on_tool_end) exposes theToolandToolContext, but does not include the actual arguments passed to the tool call.resolves #939
Solution
This implementation is inspired by PR #1598.
tool_argumentsfield toToolContextand populate it via from_agent_context with tool_call.arguments.lifecycle_example.pyto demonstrate tool_arguments in hooks