Allow readable streams to be uploaded #524
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Right now there is no way to upload files using a read stream unless it's coming from a
fs.ReadStream
. This forces the user to go through disk first before sending a stream or to reallocate the whole content to send as Buffer.In my use case I'm handling a audio stream via web API, transforming the webm via stream and, unfortunately, persisting the file before sending.
The
fs.ReadStream
already extends a stream.Readable so we can do a small extension to the code without needing to change behavior.For this PR I decided to add support for Readable instead of replacing the existing FsReadStream checks. I also know that the code is unlikely to be merged but it demonstrates a simple solution to it.