-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CADC-13697] Science Platform CI/CD Updates #697
Open
shinybrar
wants to merge
51
commits into
opencadc:main
Choose a base branch
from
shinybrar:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck for common misc errors
…he project README is now auto-generated usign helm-docs, which in turn uses README.md.gotpl as the template to populate all the update-to-date values from values.yml
…es are provided for the secrets, i.e. null and empty secret values do not result in the creation of a kubernetes secret
…configurations via dev.overrides and added docs
…, also added placeholder helm tests which can be run via `helm test base` helm tests are currently a work-in-progress
…ces, updated readme with special dev instructions
…will be deprecated
at88mph
requested changes
Oct 4, 2024
the check now runs in a docker container
added a working helm test to check weather the skaha namespace exists
All changes requested in the PR, except the one commented above have been made. Additionally,
Questions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
helm test base
, this is currently a work-in-progress..pre-commit-config.yaml
and also a separate commit message check in Github Actionshelm-docs
in the base template, with the goal to have updated/auto-generated all docs for helm charts. This feature uses theREADME.md.gotpl
file as a documentation slug.