Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Parquet as Response Format. #181

Merged
merged 11 commits into from
Feb 7, 2025
Merged

Conversation

aratikakadiya
Copy link
Contributor

No description provided.

@pdowler
Copy link
Member

pdowler commented Jan 7, 2025

For the ParquetWriterRoundtripTest: if you extended the AbstractTablesTest, you could write a complete lifecycle test pretty easily using utility methods in the base class. See CreateTableTest and LoadTableTest for examples.

  • create table with all supported datatypes
  • upload some rows
  • query with VOTable output
  • query with parquet output
  • check for correctness (minimal like you have now)

Parquet Round trip tests changes.
Copy link
Member

@pdowler pdowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this mostly looks good - just one detail noted in test code.

I haven't reviewed the ParquetWriter test class - I think I'll wait until I can can pull the changes in and run it in my dev environment before looking at those details.

Updated youcat build file.
@pdowler pdowler merged commit c9e9cd3 into opencadc:main Feb 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants