Skip to content

main <- dev #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carmichaelong merged 2 commits into from
Oct 7, 2025
Merged

main <- dev #276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c75e7f
catch FileNotFoundError before OSError
carmichaelong Oct 6, 2025
4443aa5
Merge pull request #275 from stanfordnmbl/rmtree_with_retry-patch
AlbertoCasasOrtiz Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mcserver/zipsession_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,11 +335,6 @@ def rmtree_with_retry(path, max_retries=5, backoff=0.1):
try:
shutil.rmtree(path)
return

except (PermissionError, OSError) as e:
if attempt == max_retries - 1:
raise
time.sleep(backoff * (2**attempt))

except FileNotFoundError as e:
# In case we've made it here, we've made a best effort to delete
Expand All @@ -348,6 +343,11 @@ def rmtree_with_retry(path, max_retries=5, backoff=0.1):
return
time.sleep(backoff * (2**attempt))

except (PermissionError, OSError) as e:
if attempt == max_retries - 1:
raise
time.sleep(backoff * (2**attempt))

def zipdir_contents_with_retry(dir_path, zip_path, max_retries=5, backoff=0.1):
"""
Given a source dir_path and a target zip_path, zip the folder with
Expand Down
Loading