Skip to content

Fix fetch logs on first loading the runtime logs tab #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yashodgayashan merged 1 commit into from
Jan 16, 2026
Merged

Fix fetch logs on first loading the runtime logs tab #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 26 additions & 15 deletions plugins/openchoreo-observability/src/components/RuntimeLogs/ObservabilityRuntimeLogsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ export const ObservabilityRuntimeLogsPage = () => {
fetchLogs,
loadMore,
refresh,
componentId,
projectId,
} = useRuntimeLogs(entity, organization || '', project || '', {
environmentId: filters.environmentId,
environmentName: selectedEnvironment?.resourceName || '',
Expand All @@ -77,44 +79,53 @@ export const ObservabilityRuntimeLogsPage = () => {

const { loadingRef } = useInfiniteScroll(loadMore, hasMore, logsLoading);

// Track previous backend-relevant filters to avoid unnecessary fetches
const previousBackendFiltersRef = useRef({
environmentId: filters.environmentId,
logLevel: filters.logLevel,
timeRange: filters.timeRange,
});
// Track previous filter values to detect changes
// Initialize with null to ensure initial fetch happens when all conditions are ready
const previousFiltersRef = useRef<{
environmentId: string;
logLevel: string[];
timeRange: string;
componentId: string | null;
projectId: string | null;
} | null>(null);

// Note: Auto-selection of first environment is handled by useUrlFilters hook

// Fetch logs when backend-relevant filters change
// Fetch logs when filters change or when component/project IDs become available
useEffect(() => {
const currentBackendFilters = {
const currentFilters = {
environmentId: filters.environmentId,
logLevel: filters.logLevel,
timeRange: filters.timeRange,
componentId: componentId,
projectId: projectId,
// TODO: Sort filter will be added here later
};

// Only fetch if backend-relevant filters changed
const backendFiltersChanged =
JSON.stringify(previousBackendFiltersRef.current) !==
JSON.stringify(currentBackendFilters);
// Only fetch if filters changed (null means first load)
const filtersChanged =
previousFiltersRef.current === null ||
JSON.stringify(previousFiltersRef.current) !==
JSON.stringify(currentFilters);

if (
filters.environmentId &&
selectedEnvironment &&
organization &&
project &&
backendFiltersChanged
componentId &&
projectId &&
filtersChanged
) {
fetchLogs(true);
previousFiltersRef.current = currentFilters;
}

previousBackendFiltersRef.current = currentBackendFilters;
}, [
filters.environmentId,
filters.logLevel,
filters.timeRange,
componentId,
projectId,
fetchLogs,
selectedEnvironment,
organization,
Expand Down