-
Notifications
You must be signed in to change notification settings - Fork 27
Add doc for deploying an image from private registry #236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| - **A container image** to deploy | ||
|
|
||
| ## Deploy an Image | ||
| ## Deploy a Public Image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To make this consistent?
| ## Deploy a Public Image | |
| ## Deploy from a Public Registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed via 6adfd2b
| { | ||
| "auths": { | ||
| "https://index.docker.io/v1/": { | ||
| "auth": "eW91ci1kb2NrZXJodWItdXNlcm5hbWU6eW91ci1hY2Nlc3MtdG9rZW4=" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "auth": "eW91ci1kb2NrZXJodWItdXNlcm5hbWU6eW91ci1hY2Nlc3MtdG9rZW4=" | |
| "auth": "<your-base64-auth-string>" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed via 6adfd2b
| --- | ||
| title: Deploy a Prebuilt Container Image | ||
| description: Deploy your existing container images to OpenChoreo without using the Build Plane. | ||
| description: Deploy your existing container images to OpenChoreo from public or private registries without using the Build Plane. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to mention without using Build Plane?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I included it to clarify the use case. (some users might not immediately understand why they'd deploy a prebuilt image instead of using the standard flow. It helps distinguish BYOI from the build-and-deploy approach.
| name: registry-pull-secret | ||
| namespace: ${metadata.namespace} | ||
| spec: | ||
| refreshInterval: 15s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Might be a good idea to keep refreshInterval: 1h or similar, to avoid frequent secret syncs.
Purpose
Add doc for deploying an image from private registry
Related Issues
Checklist
sidebars.tsif adding a new documentation pagenpm run startto preview the changes locallynpm run buildto ensure the build passes without errors