-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poland: add senate constituencies, updated congressional districts and README #347
Poland: add senate constituencies, updated congressional districts and README #347
Conversation
@jloutsenhizer @jpmckinney could you have a look at the changes in poland, please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me and looks accurate, at least against the wiki pages I was looking through.
I had one comment about the naming of the files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking good, with a few edits. I was initially confused because, effectively, electoral_districts.csv is renamed to congressional_district.csv, and then electoral_districts.csv is used for senate districts.
It would be clearer to rename electoral_districts.csv
to senate_districts.csv
– and while were doing that change congressional_districts.csv
to sejm_constituencies.csv
(Poland had a "Congress Poland" from 1815 to 1831, so it's confusing).
I don't think senate districts should be nested under parliament districts. They do have that correspondence, but there is no political hierarchy between these divisions (only a geographical hierarchy).
Also, Poland numbers Senate districts from 1-100, and names them "No.1 (Legnica)" etc. https://sejmsenat2019.pkw.gov.pl/sejmsenat2019/en/wyniki/senat/pl
For backwards compatibility, we'll keep the original choice of "cd" and identifier for parliamentary districts (though Poland also uses numbers here).
It does look like that is how they are primarily referred to based on poking around the 2019 election website and 2015 election website. The name that comes along with the number is the "seat of the district electoral commission" which presumably can change from election to election, as is the case with some of the ID updates in this PR. It looks like these numbers can be reused over time. Example Senate constituency no 25 (2001-2011) and Senate consituency no 25 (2011-present). So I'd propose using the senate electoral district number + the year they were established. Which I believe would be 2011 for all of the current districts. I think this would be consistent with the current proposal for Canadian districts which have a similar name re-use issue. |
Thank you for your reviews. Files will be renamed.
Just to get it right, for example
should then be
adding 42 as its number of the senate district and 2011 as the year it was established. The name for all 6 senate districts in Warszawa are identical (Warszawa), so I would add a number. Warszawa EDs begins at number 40. So number 40 would be
Removing the nesting under parliament districts, it would be like this:
|
Good catch on suffixing by year created. IDs like
Sources instead name districts as e.g. "No. 40 (Warszawa)", so let's do that instead of inventing new numbers. States (provinces) in Poland have their own elected legislatures, and so the |
…of they were established
Good call. Done.
Eds now hanging off the Can you review again, please. |
ocd-division/country:pl/ed:9-2011,No 9 (Bydgoszcz) | ||
ocd-division/country:pl/ed:10-2011,No.10 (Bydgoszcz) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The numbers less than 10 are missing a period and the numbers greater or equal to 10 are missing a space before the number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, how did i miss that! Fixed.
For the upcoming election in Poland (expected on 31st October 2023) we need to add a file for the senate constituencies of Poland.
There were changes happened to some congressional districts in 2011 and 2019.
congressional_districts.csv
electoral_districts.csv
fileA readme file for this folder was added as well.