Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poland: add senate constituencies, updated congressional districts and README #347

Merged

Conversation

zikowang
Copy link
Contributor

@zikowang zikowang commented Aug 2, 2023

For the upcoming election in Poland (expected on 31st October 2023) we need to add a file for the senate constituencies of Poland.

There were changes happened to some congressional districts in 2011 and 2019.

  • the congressional districts were moved to an own file named congressional_districts.csv
  • the electoral districts are now in the electoral_districts.csv file

A readme file for this folder was added as well.

@zikowang zikowang changed the title Added senate constituencies, updated congressional districts and README Poland: add senate constituencies, updated congressional districts and README Aug 3, 2023
@zikowang
Copy link
Contributor Author

zikowang commented Aug 7, 2023

@jloutsenhizer @jpmckinney could you have a look at the changes in poland, please?

@jloutsenhizer jloutsenhizer self-requested a review August 7, 2023 16:14
Copy link
Contributor

@jloutsenhizer jloutsenhizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me and looks accurate, at least against the wiki pages I was looking through.

I had one comment about the naming of the files.

identifiers/country-pl/congressional_districts.csv Outdated Show resolved Hide resolved
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking good, with a few edits. I was initially confused because, effectively, electoral_districts.csv is renamed to congressional_district.csv, and then electoral_districts.csv is used for senate districts.

It would be clearer to rename electoral_districts.csv to senate_districts.csv – and while were doing that change congressional_districts.csv to sejm_constituencies.csv (Poland had a "Congress Poland" from 1815 to 1831, so it's confusing).

I don't think senate districts should be nested under parliament districts. They do have that correspondence, but there is no political hierarchy between these divisions (only a geographical hierarchy).

Also, Poland numbers Senate districts from 1-100, and names them "No.1 (Legnica)" etc. https://sejmsenat2019.pkw.gov.pl/sejmsenat2019/en/wyniki/senat/pl

For backwards compatibility, we'll keep the original choice of "cd" and identifier for parliamentary districts (though Poland also uses numbers here).

@jloutsenhizer
Copy link
Contributor

jloutsenhizer commented Aug 7, 2023

Also, Poland numbers Senate districts from 1-100, and names them "No.1 (Legnica)" etc. https://sejmsenat2019.pkw.gov.pl/sejmsenat2019/en/wyniki/senat/pl

It does look like that is how they are primarily referred to based on poking around the 2019 election website and 2015 election website. The name that comes along with the number is the "seat of the district electoral commission" which presumably can change from election to election, as is the case with some of the ID updates in this PR.

It looks like these numbers can be reused over time. Example Senate constituency no 25 (2001-2011) and Senate consituency no 25 (2011-present).

So I'd propose using the senate electoral district number + the year they were established. Which I believe would be 2011 for all of the current districts. I think this would be consistent with the current proposal for Canadian districts which have a similar name re-use issue.

@zikowang
Copy link
Contributor Author

zikowang commented Aug 8, 2023

Thank you for your reviews.

Files will be renamed.

So I'd propose using the senate electoral district number + the year they were established. Which I believe would be 2011 for all of the current districts. I think this would be consistent with the current proposal for Canadian districts which have a similar name re-use issue.

Just to get it right, for example

ocd-division/country:pl/state:mz/cd:warszawa_i/ed:1,Warszawa I 3

should then be

ocd-division/country:pl/state:mz/cd:warszawa_i/ed:42-2011,Warszawa 3

adding 42 as its number of the senate district and 2011 as the year it was established.

The name for all 6 senate districts in Warszawa are identical (Warszawa), so I would add a number. Warszawa EDs begins at number 40. So number 40 would be Warszawa 1, number 41 Warszawa 2 and so on.

I don't think senate districts should be nested under parliament districts. They do have that correspondence, but there is no political hierarchy between these divisions (only a geographical hierarchy).

Removing the nesting under parliament districts, it would be like this:

ocd-division/country:pl/state:mz/ed:42-2011,Warszawa 3

@jpmckinney
Copy link
Member

Good catch on suffixing by year created. IDs like ed:25-2011 look good.

The name for all 6 senate districts in Warszawa are identical (Warszawa), so I would add a number. Warszawa EDs begins at number 40. So number 40 would be Warszawa 1, number 41 Warszawa 2 and so on.

Sources instead name districts as e.g. "No. 40 (Warszawa)", so let's do that instead of inventing new numbers.

States (provinces) in Poland have their own elected legislatures, and so the ed should not hang off the state but off the country itself.

@zikowang
Copy link
Contributor Author

zikowang commented Aug 10, 2023

Sources instead name districts as e.g. "No. 40 (Warszawa)", so let's do that instead of inventing new numbers.

Good call. Done.

States (provinces) in Poland have their own elected legislatures, and so the ed should not hang off the state but off the country itself.

Eds now hanging off the country itself.

Can you review again, please.

Comment on lines 10 to 11
ocd-division/country:pl/ed:9-2011,No 9 (Bydgoszcz)
ocd-division/country:pl/ed:10-2011,No.10 (Bydgoszcz)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The numbers less than 10 are missing a period and the numbers greater or equal to 10 are missing a space before the number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, how did i miss that! Fixed.

@jpmckinney jpmckinney merged commit 853718f into opencivicdata:master Aug 11, 2023
1 check passed
@zikowang zikowang deleted the feature/poland-update-for-senate branch January 25, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants