Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Grand Isle, VT SLDU #349

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jones-liam-j
Copy link

Fixes the Vermont State Senate district "Grand Isle" erroneously being marked as obsolete, and the non-existent "Grand Isle-Chittenden" (which is actually a lower house district) existing in its place.

According to state reapportionment records this district has been named "Grand Isle" since at least 2002; Chittenden is a separate district (or three districts, as of 2022).

Copy link
Contributor

@jloutsenhizer jloutsenhizer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I think this is a good change, once the erroneous ID is mapped to the correct ID in via a sameAs alias

@@ -179171,8 +179171,7 @@ ocd-division/country:us/state:vt/sldu:chittenden-southeast,Vermont Chittenden So
ocd-division/country:us/state:vt/sldu:essex,Vermont Essex State Senate district,,,,,,,,,,,2023-01-04
ocd-division/country:us/state:vt/sldu:essex-orleans,Vermont Essex-Orleans State Senate district,,,2023-01-03,,sldu-50E-O,sldu-50E-O,vt-upper-essex-orleans,,,,
ocd-division/country:us/state:vt/sldu:franklin,Vermont Franklin State Senate district,,,,,sldu-50FRA,sldu-50FRA,vt-upper-franklin,,,,
ocd-division/country:us/state:vt/sldu:grand_isle,Vermont Grand Isle State Senate district (obsolete),,,,,sldu-50CGI,,,,,,
ocd-division/country:us/state:vt/sldu:grand_isle-chittenden,Vermont Grand-Isle-Chittenden State Senate district,,,,,,sldu-50CGI,vt-upper-grand-isle-chittenden,,,,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of completely deleting ocd-division/country:us/state:vt/sldu:grand_isle-chittenden, it should be added to aliases.csv to mark that it is the same-as ocd-division/country:us/state:vt/sldu:grand_isle since some systems might already be using it and relying on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants