-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Australia OCD ID Update #367
Australia OCD ID Update #367
Conversation
@azuser we have also added valid through dates to Agricultural Region, East Metropolitan Region, Mining and Pastoral Region, North Metropolitan Region, South Metropolitan Region, South West Region in councils.csv and updated also updated in country-au.csv and & sorted alphabetically on ID Column. |
ocd-division/country:au/state:nsw/sldl:baulkham_hills,ocd-division/country:au/state:nsw/sldl:kellyville,Baulkham Hills renamed to Kellyville | ||
ocd-division/country:au/state:nsw/sldl:ku-ring-gai,ocd-division/country:au/state:nsw/sldl:wahroonga,Ku-ring-gai renamed to Wahroonga | ||
ocd-division/country:au/state:nsw/sldl:mulgoa,ocd-division/country:au/state:nsw/sldl:badgerys_creek,Mulgoa renamed to Badgerys Creek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the wiki for Badgerys Creek the renaming is mentioned however I was able to find anything related to this on page 13 of the PDF linked above. Do you have another source you can provide for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HKSenior This is an old change of 2023 of NSW, we are not sure, why this comment has been made here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry there was a mistype on my part.
In the wiki linked above the renaming is mentioned however it isn't mentioned in the pdf (page 13/14) linked above. Do you have an official source that confirms the renaming change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wiki Link mentioned above is not the right source for reference with respect to Western Australia . And the reference which can be used for the same is mentioned below .
The Link for the State is -
https://www.boundaries.wa.gov.au/sites/default/files/content/2023%20Review%20of%20WA's%20Electoral%20Boundaries%20-%20Final%20Report.pdf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HKSenior @GoogleCivics-Kantar Just in regards to Badgerys creek the relevant information can be seen here https://elections.nsw.gov.au/voters/electoral-districts-redistribution/names-and-boundaries-of-electoral-districts but as @GoogleCivics-Kantar is correct Badgerys Creek is in NSW not WA
@@ -1,5 +1,9 @@ | |||
id,sameAs,sameAsNote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From page 1 of the pdf (last paragraph) these changes will go in affect at the next State General Election which is due to be held in March of 2025. Add a column column called validFrom
and set all of the relevant changes validFrom
column to 2025-03
.
From page 12 of the pdf add 2 additional lines for North West Central
and Moore
to point to Mid-West
. That is:
ocd-division/country:au/state:wa/sldl:north_west_central,ocd-division/country:au/state:nsw/sldl:mid-west,North West Central renamed to Mid-West
ocd-division/country:au/state:wa/sldl:moore,ocd-division/country:au/state:nsw/sldl:mid-west,Moore renamed to Mid-West
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HKSenior The above suggestions is slightly tweaked. i.e. nsw is changed to WA. In assemblies.csv we do not have an option for putting comments. Also, we are not making changes in alias.csv because this is the case in which North West Central and Moore assemblies has been abolished and amalgamated as Mid West.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the corresponding changes in the assembles.csv file, thanks.
identifiers/country-au.csv
Outdated
ocd-division/country:au/state:wa/sldl:bicton,Bicton,,,, | ||
ocd-division/country:au/state:wa/sldl:bunbury,Bunbury,,,, | ||
ocd-division/country:au/state:wa/sldl:burns_beach,Burns Beach,,,, | ||
ocd-division/country:au/state:wa/sldl:burns_beach,Burns Beach,ocd-division/country:au/state:wa/sldl:mindarie,Burns Beach renamed to Mindarie,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the validFrom
date to this line (the date of the next State General Election). Same for other ids being added in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HKSenior validFrom dates are added in the same.
identifiers/country-au.csv
Outdated
@@ -551,37 +553,41 @@ ocd-division/country:au/state:wa/sldl:kwinana,Kwinana,,,, | |||
ocd-division/country:au/state:wa/sldl:landsdale,Landsdale,,,, | |||
ocd-division/country:au/state:wa/sldl:mandurah,Mandurah,,,, | |||
ocd-division/country:au/state:wa/sldl:maylands,Maylands,,,, | |||
ocd-division/country:au/state:wa/sldl:mid_west,Mid-West,,,,2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets be as specific as possible with the date. According to the pdf these changes go into affect in March of 2025. So lets change the validFrom
to 2025-03
. Here, above and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HKSenior validFrom dates are added in the same.
ocd-division/country:au/state:vic/sldu:western_metropolitan,Western Metropolitan | ||
ocd-division/country:au/state:vic/sldu:western_victoria,Western Victoria | ||
ocd-division/country:au/state:tas/sldu:windermere,Windermere | ||
id,name,validFrom,validThrough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide documentation to confirm these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HKSenior These changes in Victoria and Tasmania are not made by us, wrong ocd ids are being referred here. Kindly guide us which changes you are referring to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see these changes are solely reorganizing into alphabetical order.
In the future it would be best to submit 2 PRs one with the updates due to the upcoming redistricting and another as cleanup. The sorting is nice to have but can bloat diffs and make discerning between cleanup and actual changes a bit difficult to spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, we will follow this going forward
ocd-division/country:au/state:nsw/sldl:baulkham_hills,ocd-division/country:au/state:nsw/sldl:kellyville,Baulkham Hills renamed to Kellyville | ||
ocd-division/country:au/state:nsw/sldl:ku-ring-gai,ocd-division/country:au/state:nsw/sldl:wahroonga,Ku-ring-gai renamed to Wahroonga | ||
ocd-division/country:au/state:nsw/sldl:mulgoa,ocd-division/country:au/state:nsw/sldl:badgerys_creek,Mulgoa renamed to Badgerys Creek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry there was a mistype on my part.
In the wiki linked above the renaming is mentioned however it isn't mentioned in the pdf (page 13/14) linked above. Do you have an official source that confirms the renaming change?
@@ -1,5 +1,9 @@ | |||
id,sameAs,sameAsNote |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the corresponding changes in the assembles.csv file, thanks.
ocd-division/country:au/state:vic/sldu:western_metropolitan,Western Metropolitan | ||
ocd-division/country:au/state:vic/sldu:western_victoria,Western Victoria | ||
ocd-division/country:au/state:tas/sldu:windermere,Windermere | ||
id,name,validFrom,validThrough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see these changes are solely reorganizing into alphabetical order.
In the future it would be best to submit 2 PRs one with the updates due to the upcoming redistricting and another as cleanup. The sorting is nice to have but can bloat diffs and make discerning between cleanup and actual changes a bit difficult to spot.
Hi @azuser
We have made the below changes for Australia.