feat(imessage): add myNumbers config to filter by destination phone number#5654
Closed
commander-alexander wants to merge 1 commit intoopenclaw:mainfrom
Closed
Conversation
…umber
When the Mac has multiple iMessage numbers (e.g., dual-SIM setup), messages
to ALL numbers are received. This adds a myNumbers config option that filters
messages by destination_caller_id, so the bot only responds to messages sent
to the configured number(s).
Config example:
{
channels: {
imessage: {
myNumbers: ["+16466128299"]
}
}
}
Requires imsg to expose destination_caller_id (see steipete/imsg#29).
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+216
to
+228
| const myNumbers = imessageCfg.myNumbers; | ||
| if (myNumbers && myNumbers.length > 0) { | ||
| const destinationCallerId = message.destination_caller_id; | ||
| if (destinationCallerId) { | ||
| const normalizedDest = normalizeIMessageHandle(destinationCallerId); | ||
| const normalizedMyNumbers = myNumbers.map((n) => normalizeIMessageHandle(n)); | ||
| if (!normalizedMyNumbers.includes(normalizedDest)) { | ||
| logVerbose( | ||
| `imessage: skipping message to ${destinationCallerId} (not in myNumbers: ${myNumbers.join(", ")})`, | ||
| ); | ||
| return; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
[P1] myNumbers filter is bypassed when destination_caller_id is missing
In handleMessageNow, the filter only runs if destinationCallerId is truthy (if (destinationCallerId) { ... }). If imsg is older (or sends null/empty) then messages will be processed even when myNumbers is configured, which undermines the main safety goal (avoid responding on the wrong number). Consider treating missing destination_caller_id as non-matching (skip) when myNumbers is set, or at least logging a clear warning so operators know the filter isn’t being applied.
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/imessage/monitor/monitor-provider.ts
Line: 216:228
Comment:
[P1] `myNumbers` filter is bypassed when `destination_caller_id` is missing
In `handleMessageNow`, the filter only runs if `destinationCallerId` is truthy (`if (destinationCallerId) { ... }`). If `imsg` is older (or sends `null`/empty) then messages will be processed even when `myNumbers` is configured, which undermines the main safety goal (avoid responding on the wrong number). Consider treating missing `destination_caller_id` as non-matching (skip) when `myNumbers` is set, or at least logging a clear warning so operators know the filter isn’t being applied.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+221
to
+224
| const normalizedMyNumbers = myNumbers.map((n) => normalizeIMessageHandle(n)); | ||
| if (!normalizedMyNumbers.includes(normalizedDest)) { | ||
| logVerbose( | ||
| `imessage: skipping message to ${destinationCallerId} (not in myNumbers: ${myNumbers.join(", ")})`, |
Contributor
There was a problem hiding this comment.
[P3] Avoid per-message re-normalization of myNumbers
normalizedMyNumbers is recomputed on every inbound message (myNumbers.map(normalizeIMessageHandle)), even though imessageCfg.myNumbers is static for the provider lifetime. Precomputing a Set of normalized numbers once (outside handleMessageNow) would avoid repeated allocations and make the membership check O(1).
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/imessage/monitor/monitor-provider.ts
Line: 221:224
Comment:
[P3] Avoid per-message re-normalization of `myNumbers`
`normalizedMyNumbers` is recomputed on every inbound message (`myNumbers.map(normalizeIMessageHandle)`), even though `imessageCfg.myNumbers` is static for the provider lifetime. Precomputing a `Set` of normalized numbers once (outside `handleMessageNow`) would avoid repeated allocations and make the membership check O(1).
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[This PR was closed and replaced by #5655 - content removed for privacy]