Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site bug #96

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Site bug #96

merged 10 commits into from
Nov 12, 2024

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Nov 12, 2024 •
edited
Loading

Pull Request

Description

  • solve bug for getting forecasts and generation with site uuid.
  • This was due to str != UUID

How Has This Been Tested?

Added to tests
Ran it locally to check

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield requested a review from devsjc November 12, 2024 12:47
@peterdudfield peterdudfield merged commit aed02e5 into main Nov 12, 2024
8 checks passed
@peterdudfield peterdudfield deleted the site-bug branch November 12, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsjc devsjc Awaiting requested review from devsjc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@peterdudfield