Skip to content

Comments

install forwarding, add plugin and url, add forward in md#461

Merged
Svanvith merged 2 commits intomainfrom
add-forwarding
Sep 12, 2025
Merged

install forwarding, add plugin and url, add forward in md#461
Svanvith merged 2 commits intomainfrom
add-forwarding

Conversation

@Svanvith
Copy link
Contributor

@AlexAndBear now with forwarding. Please look again if this is now approveabale :)

@micbar the local instructions are deleted and forwarded now to the docker compose installation

{
redirects: [
{
from: ['/docs/admin/getting-started/container/docker-compose-local'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need the mapping in two locations?

  1. Here
  2. In the file docs/admin/getting-started/container/docker-compose/docker-compose-base.md

I am wondering if this is redundant.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it works in the config.ts only, i would prefer to have the redirects only there, because that is easier to maintain.

@AlexAndBear Agree?

Copy link
Member

@AlexAndBear AlexAndBear Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add an redirect.ts file and import the array from there for maintainance and as you said, remove it from the markdown file if possible

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to do it. Found out that we can omit the front matter.

NOTE: This only works when we really build the docs, pnpm start doesn't cover it.

@micbar
Copy link
Member

micbar commented Sep 11, 2025

@Svanvith Please pull and test my changes. They only work if you run

  • pnpm build
  • pnpm run serve

@Svanvith
Copy link
Contributor Author

works with your changes @micbar

@Svanvith Svanvith merged commit f4ff303 into main Sep 12, 2025
2 checks passed
@Svanvith Svanvith deleted the add-forwarding branch September 12, 2025 10:09
@openclouders openclouders mentioned this pull request Sep 12, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants