Fix concurrent access to app tokens#527
Merged
rhafer merged 7 commits intoopencloud-eu:mainfrom Feb 17, 2026
Merged
Conversation
According to the CS3 specs (https://github.com/cs3org/cs3apis/blob/main/cs3/rpc/v1beta1/code.proto) the correct status code to return for a request that a client "should retry on a higher level" is 'Aborted' (we map that to the HTTP Status "Precondition Failed"). The 'FailedPrecondition' CS3 status is supposed to be used for cases where a client should not retry (usually mapped to the HTTP Status "Conflict" or "Bad Request")
- check for the 'Aborted' status code for whether the upload should be retries. Due to a bug previously the storageprovider could return either 'Aborted' or 'FailedPrecondition'. We were only checking for 'FailedPrecondtion' and missed a couple of case for retry due to that. Now the storeageprovider always returns 'Aborted'. - workaround for 425 Status: Even with async_uploads disable we sometimes get a 425 Status when trying to download a file to which an upload is currently in progress (bug report pending). This adds a workaround to the jsoncs3 apptoken manager to retry the download after a short timeout. Fixes: opencloud-eu/opencloud#2023
With the additional test the test-suite not often needs more that 10 minutes
Allow to increase the number of retries for the apptoken update for testing.
aduffeck
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: opencloud-eu/opencloud#2023