refactor!: port vue-portal to teleport or extension system#2015
Open
JammingBen wants to merge 1 commit intomainfrom
Open
refactor!: port vue-portal to teleport or extension system#2015JammingBen wants to merge 1 commit intomainfrom
JammingBen wants to merge 1 commit intomainfrom
Conversation
af8ab7f to
617f6e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes for
portalundportal-targetusages$wormholeon vue instance has been removedPortalTargetcomponent has been removedapp.files.sidebar.file.details.tableportal target has been removed. Register an extension on theapp.files.sidebar.file-details.tableextension point instead.app.files.sidebar.space.details.tableportal target has been removed. Register an extension to theapp.files.sidebar.space-details.tableextension point instead.app.files.sidebar.sharing.shared-with.topportal target has been removed. Register an extension on theapp.files.sidebar.shares-panel.shared-with.topextension point instead.app.files.sidebar.sharing.shared-with.bottomportal target has been removed. Register an extension on theapp.files.sidebar.shares-panel.shared-with.bottomextension point instead.app.runtime.header.leftportal target has been removed. Register an extension on theapp.runtime.header.leftextension point instead.app.runtime.header.rightportal target has been removed. Register an extension on theapp.runtime.header.rightextension point instead.Portals intended for internal use (e.g. the bottom drawer), I didn't replace with new extension points but with teleports. Also, extensions of type
CustomComponentExtensioncan now have properties via the newcomponentPropsproperty.closes #1936