Generalize IRContext.WellFormed by allowing missing uses #128
+15
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the proofs related to `insertIntoCurrent`, we need to be in a state where the IR is well formed except for some uses.
tobiasgrosser
approved these changes
Jan 20, 2026
Collaborator
tobiasgrosser
left a comment
tobiasgrosser
left a comment
There was a problem hiding this comment.
LGTM, just one comment.
luisacicolini
approved these changes
Jan 20, 2026
ineol
reviewed
Jan 20, 2026
Veir/IR/WellFormed.lean
Outdated
| inBounds : ctx.FieldsInBounds | ||
| valueDefUseChains (valuePtr : ValuePtr) (valuePtrInBounds : valuePtr.InBounds ctx) : | ||
| ∃ array, ValuePtr.DefUse valuePtr ctx array | ||
| ∃ array, ValuePtr.DefUse valuePtr ctx array (missingOperandUses.filter (λ use => (use.get! ctx).value = valuePtr)) |
Collaborator
There was a problem hiding this comment.
Can you write ((\cdot.get! ctx).value = valuePtr) instead?
Collaborator
Author
There was a problem hiding this comment.
This doesn't work for me, because (\cdot.get! ctx).value = valuePtr makes the inner parenthesis a function, so .value doesn't work after that.
ineol
reviewed
Jan 20, 2026
|
|
||
| deriving instance DecidableEq for Except | ||
|
|
||
| @[simp, grind =] |
Collaborator
Author
There was a problem hiding this comment.
So https://leanprover-community.github.io/mathlib4_docs/Std/Data/ExtHashSet/Lemmas.html#Std.ExtHashSet.filter_eq_empty_iff is the nearest theorem, otherwise there is no existing theorem like this.
grind = is necessary for some proofs when I checked.
ineol
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the proofs related to
insertIntoCurrent, we need to be in a state where the IR is well formed except for some uses.