Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IS-IS Graceful Restart nodes #1253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

earies
Copy link
Contributor

@earies earies commented Feb 10, 2025

  • (M) release/models/isis/openconfig-isis-lsp.yang
  • (M) release/models/isis/openconfig-isis-routing.yang
  • (M) release/models/isis/openconfig-isis.yang
    • Refactor IS-IS GR leaves according to RFC, remove defaults
    • Removal of non-standard interface-time-expirations leaf

Change Scope

This change involves:

  • Removal of any graceful-restart timer defaults. There are no such defaults
    agreed upon across implementations and usage can vary per use-case.
  • Addition of units statements to represent correct time unit
  • Refactor grouping names to align w/ the usage (level/system)
  • Removal of interface-time-expirations leaf as there is only 1 referenced
    implementation. Suggestion would be an augmentation or usage of native
    modeling in such cases vs. everyone else deviating.
  • Correct description statements/RFC references

This change is backwards incompatible though likely reduced impact due to
implementation status.

Platform Implementations

  • RFC compliance
  • Removal of interface-time-expirations leaf as there was only 1 prior
    implementation reference.

  * (M) release/models/isis/openconfig-isis-lsp.yang
  * (M) release/models/isis/openconfig-isis-routing.yang
  * (M) release/models/isis/openconfig-isis.yang
    - Refactor IS-IS GR leaves according to RFC, remove defaults
    - Removal of non-standard `interface-time-expirations` leaf
@earies earies requested a review from a team as a code owner February 10, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant