Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(env-vars): check env vars in production for migration #7649

Merged
merged 5 commits into from
Oct 2, 2024

Conversation

naftis
Copy link
Collaborator

@naftis naftis commented Sep 24, 2024

#5932

Refactors migration to enforce setting environment variables in production. Doesn't use envalid to keep things simple.

NOTE!: Also adds a set -e to run-migrations.sh to fail the whole script if any of the commands fails. I thought this is necessary for example in the case of reindexing search, if the Mongo migrations fail, the ElasticSearch gets bad data also.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@naftis naftis added this to the v1.7.0 milestone Sep 24, 2024
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-5932-migration.opencrvs.dev.

@naftis naftis merged commit c5f2d1a into develop Oct 2, 2024
39 checks passed
@naftis naftis deleted the ocrvs-5932-migration branch October 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants