Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(env-vars): use envalid in user-mgnt #7651

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

naftis
Copy link
Collaborator

@naftis naftis commented Sep 24, 2024

#5932

Refactors user-mgnt to use envalid and enforce setting environment variables in production. I amended the MINIO_BUCKET to user-mgnt as well, because gateway also has it set explicit in docker-compose.

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@@ -177,6 +177,7 @@ services:
- FHIR_URL=http://hearth:3447/fhir
- APPLICATION_CONFIG_URL=http://config:2021/
- DOCUMENTS_URL=http://documents:9050
- MINIO_BUCKET=ocrvs
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rikukissa wonder if it should be implicit or explicit in all services? now gateway has it set but user-mgnt didn't. I amended it for consistency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could make it explicit for all services that use it, yea 👍

@naftis naftis added this to the v1.7.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants