Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility improvement in Choose New Password page #7665

Merged
merged 17 commits into from
Oct 2, 2024

Conversation

HabibSentongo
Copy link
Collaborator

@HabibSentongo HabibSentongo commented Sep 25, 2024

Fixes #5502

  • Add onKeyDown handler function to check for Enter/Return key press.
  • Register this handler function on both input fields.
  • Add tests for this added functionality.

HabibSentongo and others added 2 commits September 25, 2024 15:56
- Add onKeyDown handler function to check to Enter/Return key press.
- Call this handler function on both input fields.
- Add tests for this added functionality.
Copy link
Collaborator

@Zangetsu101 Zangetsu101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @HabibSentongo . Just one small change request

Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@Zangetsu101
Copy link
Collaborator

@HabibSentongo It looks like the tests are failing. You can ignore the one that's unrelated to your changes i.e. the FormFieldGenerator test but some of the tests that you wrote for the ChangePassword page are failing. You can run the tests locally by "cd"ing into packages/client and running yarn test
Pro tip: you can run tests for a single file too by running something like this yarn test:watch ChangePassword

CHANGELOG.md Outdated Show resolved Hide resolved
@Zangetsu101 Zangetsu101 merged commit 077fc79 into opencrvs:develop Oct 2, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessibility improvement in choose new password page
3 participants