feat(message-queue): allow confirming and rejecting record externally #7674
+738
−157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
naftis
commented
Sep 26, 2024
Comment on lines
1242
to
1245
| export const enum GQLRejectionReason { | ||
| other = 'other', | ||
| duplicate = 'duplicate' | ||
| } |
There was a problem hiding this comment.
As far as I can see, this frontend code acts as a source of truth for the rejection reasons... we must refactor this to be stricter.
it would be the correct REST action for the state changes: chose convention for now
naftis
commented
Sep 26, 2024
naftis
commented
Sep 26, 2024
| @@ -0,0 +1,53 @@ | |||
| /* | |||
There was a problem hiding this comment.
Test required for this endpoint
|
Your environment is deployed to https://ocrvs-6208-reject-registration.opencrvs.dev. |
6 tasks
naftis
force-pushed
the
ocrvs-6208-reject-registration
branch
from
bd84e0e
to
c2db318
Compare
naftis
commented
Sep 30, 2024
Comment on lines
-93
to
-96
| case 'misspelling': | ||
| return rejectMessages.rejectionReasonMisspelling | ||
| case 'missing_supporting_doc': | ||
| return rejectMessages.rejectionReasonMissingSupportingDoc |
There was a problem hiding this comment.
Can you please double-check these aren't used anywhere? I only found the strings from tests and I'm planning to remove the tests that refer to these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Country-config: opencrvs/opencrvs-countryconfig#288
Creates two new GraphQL endpoints:
This will also enable integrations such as MOSIP 'hijacking' the confirm path and only doing it when they are ready.
Todo: