[fix] optimize some metric style in curvefs #2417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xinlong Chen <xl_chen@zju.edu.cn>
|
cicheck |
Xinlong-Chen
changed the title
wu-hanqing
approved these changes
Apr 23, 2023
ilixiaocui
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2319
Problem Summary: Use
static const std::string xxxto replaceconst std::string xxxin a struct type.What is changed and how it works?
What's Changed: some metric class in
curvefs/src/client/metric, add a cpp file to initialize it;How it Works: static variables only have one copy for all objects, so it occupy less memory in this way.
Side effects(Breaking backward compatibility? Performance regression?):
Check List