Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new deploy type #350

Closed
wants to merge 1 commit into from
Closed

add new deploy type #350

wants to merge 1 commit into from

Conversation

WhereAreBugs
Copy link

#257
And if there any other things I required to do?

@WhereAreBugs
add deploy type
ec0505f 
Signed-off-by: WhereAreBugs <2572414306@qq.com>
@WhereAreBugs WhereAreBugs marked this pull request as ready for review November 22, 2023 08:38
@aspirer
Copy link
Collaborator

aspirer commented Nov 23, 2023

  1. We should store the deployType to curveadm db, then we can query/display the deployType when we need
  2. the branch you pusded should be develop, not tombstone

@WhereAreBugs
Copy link
Author

I see, I will fix it soon and now I will close this pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WhereAreBugs @aspirer