Preserve sort order for indirect attributes #436

pcoccoli · 2023-12-01T21:20:28Z

Fixes #435

codecov · 2023-12-01T21:27:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b86d637) 84.87% compared to head (9cb4c96) 86.33%.
Report is 86 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #436      +/-   ##
===========================================
+ Coverage    84.87%   86.33%   +1.45%     
===========================================
  Files           56       51       -5     
  Lines         3412     2964     -448     
===========================================
- Hits          2896     2559     -337     
+ Misses         516      405     -111

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

subbyte

May add an additional assert in test.

packages/kestrel_core/tests/test_command_assign.py

pcoccoli added 2 commits December 1, 2023 16:01

fix sort for indirect attributes

62b13f4

Require firepit>=2.3.30

9cb4c96

pcoccoli requested a review from subbyte December 1, 2023 21:20

subbyte approved these changes Dec 1, 2023

View reviewed changes

packages/kestrel_core/tests/test_command_assign.py Show resolved Hide resolved

pcoccoli merged commit a93a3f0 into develop Dec 4, 2023
41 checks passed

pcoccoli deleted the sort_indirect branch December 4, 2023 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Preserve sort order for indirect attributes #436

Preserve sort order for indirect attributes #436

pcoccoli commented Dec 1, 2023

codecov bot commented Dec 1, 2023

subbyte left a comment

Preserve sort order for indirect attributes #436

Preserve sort order for indirect attributes #436

Conversation

pcoccoli commented Dec 1, 2023

codecov bot commented Dec 1, 2023

Codecov Report

subbyte left a comment

Choose a reason for hiding this comment