Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pydev debug #955

Merged
merged 4 commits into from
Oct 24, 2023
Merged

Pydev debug #955

merged 4 commits into from
Oct 24, 2023

Conversation

SpacemanPaul
Copy link
Contributor

@SpacemanPaul SpacemanPaul commented Oct 23, 2023

As raised in #953, the $PYDEV_DEBUG environment variable's value was not checked - setting it to anything other than an empty string resulted in debugging being turned on. As the examples in documentation set it to "yes", this caused confusion with explicitly setting the environment variable to e.g. "no" resulted in debugging being turned on.

This PR checks for the following values: "N", "NO", F" and "FALSE" (evaluated case insensitively) and treats them as deactivating debugging.

(This PR also manually applies the pre-commit updates raised by pre-commit-ci in #951)


📚 Documentation preview 📚: https://datacube-ows--955.org.readthedocs.build/en/955/

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #955 (a3565a3) into master (e08f9cc) will decrease coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
- Coverage   93.73%   93.72%   -0.01%     
==========================================
  Files          43       43              
  Lines        6496     6489       -7     
==========================================
- Hits         6089     6082       -7     
  Misses        407      407              
Files Coverage Δ
datacube_ows/__init__.py 100.00% <100.00%> (ø)
datacube_ows/ogc.py 85.18% <ø> (-0.53%) ⬇️
datacube_ows/startup_utils.py 92.61% <80.00%> (-0.10%) ⬇️

SpacemanPaul added a commit that referenced this pull request Oct 24, 2023
@omad omad merged commit 80988e8 into master Oct 24, 2023
13 checks passed
@omad omad deleted the pydev_debug branch October 24, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants