Cleanup #176
Open
Cleanup #176
+130
−172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
force-pushed
the
cleanup
branch
2 times, most recently
from
164b2f4
to
adfcc06
Compare
`subprocess.NoSuchProcess` does not exist. The `ProcessLookupError` case is handled already by the subprocess package. Also, no need to catch the general Exception. Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
Wait 10sec for a response. Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
MichaelClifford
requested changes
Nov 18, 2024
Comment on lines
+102
to
103
| # from eval.mmlu import load_mmlu_results_op, run_mmlu_op | ||
| ## from eval.mmlu import run_mmlu_op, load_mmlu_results_op |
There was a problem hiding this comment.
Why not just remove these 2 lines? Why comment them out?
| @@ -119,12 +118,11 @@ def pipeline( | |||
| base_model: str = BASE_MODEL, | |||
| # minimal subset of MMLU_TASKS | |||
| # mmlu_tasks_list: str = MMLU_TASKS_LIST, | |||
| model_dtype: str = MODEL_DTYPE, | |||
| # model_dtype: str = MODEL_DTYPE, | |||
| @@ -9,7 +9,6 @@ | |||
| CreatePVC, | |||
| DeletePVC, | |||
| mount_pvc, | |||
| set_image_pull_policy, | |||
There was a problem hiding this comment.
This is actually used here:
Lines 420 to 421 in ac474e1
So I would not remove it. But probably we want to implement a better solution than having the user uncomment code.
|
Just a couple minor nits. Also, would like @sallyom to take a look as there are a few changes to the eval components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a429b67 fix: remove non-existent member
32e6ded fix: add missing import
17124a9 fix: add encoding to open call
6b15973 fix: remove unused imports
2503d86 fix: silence unused variables
abce864 fix: add timeout to requests.get
f416e44 fix: remove unused "device" variable
74012d3 fix: gen new pipeline and standalone
commit a429b67
Author: Sébastien Han seb@redhat.com
Date: Thu Nov 14 13:51:23 2024 +0100
commit 32e6ded
Author: Sébastien Han seb@redhat.com
Date: Thu Nov 14 14:18:23 2024 +0100
commit 17124a9
Author: Sébastien Han seb@redhat.com
Date: Thu Nov 14 14:19:07 2024 +0100
commit 6b15973
Author: Sébastien Han seb@redhat.com
Date: Thu Nov 14 14:20:17 2024 +0100
commit 2503d86
Author: Sébastien Han seb@redhat.com
Date: Thu Nov 14 14:20:57 2024 +0100
commit abce864
Author: Sébastien Han seb@redhat.com
Date: Thu Nov 14 14:24:06 2024 +0100
commit f416e44
Author: Sébastien Han seb@redhat.com
Date: Thu Nov 14 14:22:28 2024 +0100
commit 74012d3
Author: Sébastien Han seb@redhat.com
Date: Thu Nov 14 14:29:05 2024 +0100